Skip to content

Commit ac4da36

Browse files
committed
Merge branch 'km/new-pin-service-interface' of github.com:bitwarden/clients into km/new-pin-service-interface
2 parents 2aca230 + 813f9ca commit ac4da36

File tree

695 files changed

+37364
-15397
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

695 files changed

+37364
-15397
lines changed

.github/CODEOWNERS

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ apps/desktop/desktop_native/core/src/ssh_agent @bitwarden/team-autofill-desktop-
162162
libs/components @bitwarden/team-ui-foundation
163163
libs/assets @bitwarden/team-ui-foundation
164164
libs/ui @bitwarden/team-ui-foundation
165+
libs/angular/src/scss @bitwarden/team-ui-foundation
165166
apps/browser/src/platform/popup/layout @bitwarden/team-ui-foundation
166167
apps/browser/src/popup/app-routing.animations.ts @bitwarden/team-ui-foundation
167168
apps/browser/src/popup/components/extension-anon-layout-wrapper @bitwarden/team-ui-foundation
@@ -204,10 +205,11 @@ apps/web/src/locales/en/messages.json
204205
.github/workflows/release-desktop.yml @bitwarden/dept-bre
205206
.github/workflows/release-web.yml @bitwarden/dept-bre
206207

207-
## Docker files have shared ownership ##
208+
## Docker-related files
208209
**/Dockerfile @bitwarden/team-appsec @bitwarden/dept-bre
209210
**/*.Dockerfile @bitwarden/team-appsec @bitwarden/dept-bre
210211
**/*.dockerignore @bitwarden/team-appsec @bitwarden/dept-bre
212+
**/docker-compose.yml @bitwarden/team-appsec @bitwarden/dept-bre
211213
**/entrypoint.sh @bitwarden/team-appsec @bitwarden/dept-bre
212214

213215
## Overrides

.github/renovate.json5

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@
147147
"@nx/eslint",
148148
"@nx/jest",
149149
"@nx/js",
150+
"@nx/webpack",
150151
"@types/chrome",
151152
"@types/firefox-webext-browser",
152153
"@types/glob",

.github/workflows/alert-ddg-files-modified.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- 'apps/desktop/src/services/encrypted-message-handler.service.ts'
3131
3232
- name: Remove past BIT status comments
33-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
33+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
3434
with:
3535
script: |
3636
// Note: should match the first line of `message` in the communication steps
@@ -67,7 +67,7 @@ jobs:
6767
6868
- name: Comment on PR if monitored files changed
6969
if: steps.changed-files.outputs.monitored == 'true'
70-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
70+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
7171
with:
7272
script: |
7373
const changedFiles = `${{ steps.changed-files.outputs.monitored_files }}`.split(' ').filter(file => file.trim() !== '');

.github/workflows/auto-reply-discussions.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
steps:
1616
- name: Get discussion label and template name
1717
id: discussion-label
18-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
18+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
1919
with:
2020
script: |
2121
const discussion = context.payload.discussion;
@@ -29,7 +29,7 @@ jobs:
2929
3030
- name: Get selected topic
3131
id: get_selected_topic
32-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
32+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
3333
with:
3434
result-encoding: string
3535
script: |
@@ -45,7 +45,7 @@ jobs:
4545
}
4646
4747
- name: Reply or close Discussion
48-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
48+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
4949
env:
5050
TEMPLATE_NAME: ${{ steps.discussion-label.outputs.template_name }}
5151
TOPIC: ${{ steps.get_selected_topic.outputs.result }}

.github/workflows/build-web.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ jobs:
409409
uses: bitwarden/gh-actions/azure-logout@main
410410

411411
- name: Trigger web vault deploy using GitHub Run ID
412-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
412+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
413413
with:
414414
github-token: ${{ steps.retrieve-secret-pat.outputs.github-pat-bitwarden-devops-bot-repo-scope }}
415415
script: |

.github/workflows/lint.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ jobs:
4949
! -path "*/Cargo.toml" \
5050
! -path "*/Cargo.lock" \
5151
! -path "./apps/desktop/macos/*" \
52+
! -path "*/CLAUDE.md" \
5253
> tmp.txt
5354
diff <(sort .github/whitelist-capital-letters.txt) <(sort tmp.txt)
5455

.github/workflows/nx.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,5 @@ jobs:
3838
uses: nrwl/nx-set-shas@826660b82addbef3abff5fa871492ebad618c9e1 # v4.3.3
3939

4040
- name: Run Nx affected tasks
41+
continue-on-error: true
4142
run: npx nx affected -t build lint test

.github/workflows/publish-web.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ jobs:
179179
uses: bitwarden/gh-actions/azure-logout@main
180180

181181
- name: Trigger self-host build
182-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
182+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
183183
with:
184184
github-token: ${{ steps.retrieve-secret-pat.outputs.github-pat-bitwarden-devops-bot-repo-scope }}
185185
script: |

.github/workflows/review-code.yml

Lines changed: 109 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,109 @@
1+
name: Review code
2+
3+
on:
4+
pull_request:
5+
types: [opened, synchronize, reopened]
6+
7+
permissions: {}
8+
9+
jobs:
10+
review:
11+
name: Review
12+
runs-on: ubuntu-24.04
13+
permissions:
14+
contents: read
15+
id-token: write
16+
pull-requests: write
17+
18+
steps:
19+
- name: Check out repo
20+
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
21+
with:
22+
fetch-depth: 0
23+
persist-credentials: false
24+
25+
- name: Check for Vault team changes
26+
id: check_changes
27+
run: |
28+
# Ensure we have the base branch
29+
git fetch origin ${{ github.base_ref }}
30+
31+
echo "Comparing changes between origin/${{ github.base_ref }} and HEAD"
32+
CHANGED_FILES=$(git diff --name-only origin/${{ github.base_ref }}...HEAD)
33+
34+
if [ -z "$CHANGED_FILES" ]; then
35+
echo "Zero files changed"
36+
echo "vault_team_changes=false" >> $GITHUB_OUTPUT
37+
exit 0
38+
fi
39+
40+
# Handle variations in spacing and multiple teams
41+
VAULT_PATTERNS=$(grep -E "@bitwarden/team-vault-dev(\s|$)" .github/CODEOWNERS 2>/dev/null | awk '{print $1}')
42+
43+
if [ -z "$VAULT_PATTERNS" ]; then
44+
echo "⚠️ No patterns found for @bitwarden/team-vault-dev in CODEOWNERS"
45+
echo "vault_team_changes=false" >> $GITHUB_OUTPUT
46+
exit 0
47+
fi
48+
49+
vault_team_changes=false
50+
for pattern in $VAULT_PATTERNS; do
51+
echo "Checking pattern: $pattern"
52+
53+
# Handle **/directory patterns
54+
if [[ "$pattern" == "**/"* ]]; then
55+
# Remove the **/ prefix
56+
dir_pattern="${pattern#\*\*/}"
57+
# Check if any file contains this directory in its path
58+
if echo "$CHANGED_FILES" | grep -qE "(^|/)${dir_pattern}(/|$)"; then
59+
vault_team_changes=true
60+
echo "✅ Found files matching pattern: $pattern"
61+
echo "$CHANGED_FILES" | grep -E "(^|/)${dir_pattern}(/|$)" | sed 's/^/ - /'
62+
break
63+
fi
64+
else
65+
# Handle other patterns (shouldn't happen based on your CODEOWNERS)
66+
if echo "$CHANGED_FILES" | grep -q "$pattern"; then
67+
vault_team_changes=true
68+
echo "✅ Found files matching pattern: $pattern"
69+
echo "$CHANGED_FILES" | grep "$pattern" | sed 's/^/ - /'
70+
break
71+
fi
72+
fi
73+
done
74+
75+
echo "vault_team_changes=$vault_team_changes" >> $GITHUB_OUTPUT
76+
77+
if [ "$vault_team_changes" = "true" ]; then
78+
echo ""
79+
echo "✅ Vault team changes detected - proceeding with review"
80+
else
81+
echo ""
82+
echo "❌ No Vault team changes detected - skipping review"
83+
fi
84+
85+
- name: Review with Claude Code
86+
if: steps.check_changes.outputs.vault_team_changes == 'true'
87+
uses: anthropics/claude-code-action@a5528eec7426a4f0c9c1ac96018daa53ebd05bc4 # v1.0.7
88+
with:
89+
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
90+
track_progress: true
91+
prompt: |
92+
REPO: ${{ github.repository }}
93+
PR NUMBER: ${{ github.event.pull_request.number }}
94+
TITLE: ${{ github.event.pull_request.title }}
95+
BODY: ${{ github.event.pull_request.body }}
96+
AUTHOR: ${{ github.event.pull_request.user.login }}
97+
98+
Please review this pull request with a focus on:
99+
- Code quality and best practices
100+
- Potential bugs or issues
101+
- Security implications
102+
- Performance considerations
103+
104+
Note: The PR branch is already checked out in the current working directory.
105+
106+
Provide detailed feedback using inline comments for specific issues.
107+
108+
claude_args: |
109+
--allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*)"

.github/workflows/test-browser-interactions.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jobs:
1111
check-files:
1212
name: Check files
1313
runs-on: ubuntu-22.04
14+
if: ${{ github.event.workflow_run.conclusion == 'success' }}
1415
permissions:
1516
actions: write
1617
contents: read

0 commit comments

Comments
 (0)