Skip to content

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 13, 2025

๐ŸŽŸ๏ธ Tracking

PM-26896

๐Ÿ“” Objective

This PR updates the way Autofill works in order to avoid misaddressing the username/password to the wrong web-domain which can leak user data.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@david-livefront david-livefront added the hold do not merge yet label Oct 13, 2025
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 996ecb03-62ad-451c-b5cf-6f3110d32969

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

โŒ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
โœ… Project coverage is 84.59%. Comparing base (7ea8750) to head (7a5bbdf).
โš ๏ธ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...twarden/data/autofill/parser/AutofillParserImpl.kt 66.66% 0 Missing and 1 partial โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6014      +/-   ##
==========================================
- Coverage   84.62%   84.59%   -0.03%     
==========================================
  Files         732      722      -10     
  Lines       55052    54891     -161     
  Branches     7581     7578       -3     
==========================================
- Hits        46588    46437     -151     
+ Misses       5808     5798      -10     
  Partials     2656     2656              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold do not merge yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant