PM-17660: Improve the way we remember the annotated string

[david-livefront]

🎟️ Tracking

PM-17660

📔 Objective

This Pr updates the toAnnotatedString extension in order to better optimize the logic and ensure it updates at appropriate times.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 2b8a1700-2920-4c30-a03c-370edab31940

Great job, no security vulnerabilities found in this Pull Request

[david-livefront]

I stumbled upon this and it looks like this was supposed to be a test tag and it got updated to a content description in a previous PR by mistake. Small bit of cleanup here.

[david-livefront]

I left the int extension in place but this function feels more compose idiomatic. Kinda like the existing stringResource function.

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.63%. Comparing base (21b8ef9) to head (35db468).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...arden/ui/platform/base/util/StringResExtensions.kt	58.33%	0 Missing and 5 partials ⚠️
.../auth/feature/createaccount/CreateAccountScreen.kt	50.00%	3 Missing ⚠️
...ature/startregistration/StartRegistrationScreen.kt	70.00%	3 Missing ⚠️
...en/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt	60.00%	2 Missing ⚠️
...rtlogins/components/ImportLoginsInstructionStep.kt	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5257      +/-   ##
==========================================
+ Coverage   82.55%   82.63%   +0.07%     
==========================================
  Files         698      676      -22     
  Lines       51735    51089     -646     
  Branches     6957     6954       -3     
==========================================
- Hits        42712    42217     -495     
+ Misses       6711     6558     -153     
- Partials     2312     2314       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[david-livefront]

Thanks @SaintPatrck