[PM-21577] Handle organization limitItemDeletion from sync response. #5244
+127
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
andrebispo5
requested review from
brian-livefront,
david-livefront and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5244 +/- ##
==========================================
+ Coverage 81.65% 82.55% +0.89%
==========================================
Files 874 694 -180
Lines 57412 51648 -5764
Branches 7299 6950 -349
==========================================
- Hits 46882 42637 -4245
+ Misses 8029 6702 -1327
+ Partials 2501 2309 -192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -347,6 +347,9 @@ data class SyncResponseJson( | |||
|
|
|||
| @SerialName("userIsClaimedByOrganization") | |||
| val userIsClaimedByOrganization: Boolean = false, | |||
|
|
|||
| @SerialName("limitItemDeletion") | |||
| val limitItemDeletion: Boolean = false, | |||
There was a problem hiding this comment.
Can you make sure to add a doc for this and add an override for the test fixture as well
SaintPatrck
reviewed
May 22, 2025
app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/Organization.kt
Show resolved
Hide resolved
app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/util/CollectionViewExtensions.kt
Show resolved
Hide resolved
| @@ -12,6 +12,8 @@ import com.bitwarden.network.model.OrganizationType | |||
| * @property shouldUseKeyConnector Indicates that the organization uses a key connector. | |||
| * @property role The user's role in the organization. | |||
| * @property keyConnectorUrl The key connector domain (if applicable). | |||
| * @property userIsClaimedByOrganization Indicates that the user is claimed by the organization. | |||
| @@ -93,6 +93,7 @@ fun createMockOrganization( | |||
| familySponsorshipValidUntil: ZonedDateTime? = ZonedDateTime.parse("2023-10-27T12:00:00Z"), | |||
| status: OrganizationStatusType = OrganizationStatusType.ACCEPTED, | |||
| userIsClaimedByOrganization: Boolean = false, | |||
| limitItemDeletion: Boolean = false, | |||
david-livefront
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21577
📔 Objective
When organization
Limit item deletion to Members with Manage permissionis off, users withCan Editpermission orCan edit, hide passwordpermission should be able to see the delete button in the menu.📸 Screenshots
Soon™
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes