[PM-21891] Migrate BitwardenOutlinedButton to UI module #5242
+132
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames all `java` source directories to `kotlin`.
This commit replaces the `rememberVectorPainter` composable from `authenticator` with the one provided by the platform UI module. This change promotes code reuse and consistency across the application. The following files were updated to use the platform UI version of `rememberVectorPainter`: - `ItemListingScreen.kt` - `BitwardenActionCard.kt` - `BitwardenExternalLinkRow.kt` - `BitwardenSearchActionItem.kt` - `TutorialScreen.kt` - `SettingsScreen.kt` - `BitwardenStandardIconButton.kt` - `DebugMenuScreen.kt` - `BitwardenStepper.kt` The authenticator `rememberVectorPainter.kt` file has been deleted.
The standard, filled, and tonal icon button composables have been moved from the `app` module to the `ui` module. This also includes the associated `BitwardenIconButtonColors` file. Additionally, the `BitwardenIconButtonWithResource` composable, previously in the authenticator module, has been removed as it was not being used. The `ic_question_circle` drawable has been added to the `ui` module to support previews for these components. All usages of these icon buttons across the application have been updated to reflect this change.
This commit introduces a type alias `BitwardenDrawable` for `com.bitwarden.ui.R.drawable`. This allows for a more concise and consistent way to reference drawable resources from the `ui` module. The following files have been updated to use `BitwardenDrawable`: - `BitwardenRowOfActions.kt` - `BitwardenTonalIconButton.kt` - `BitwardenFilledIconButton.kt` - `BitwardenStandardIconButton.kt` - `BitwardenOutlinedButton.kt` - `BitwardenFilledButton.kt` - `CompleteRegistrationScreen.kt` - `BitwardenOutlinedErrorButton.kt` - `BitwardenFilledErrorButton.kt`
This commit moves the `BitwardenOutlinedButton` composable and its associated `BitwardenOutlinedButtonColors` data class from the `app` module to the `ui` module. This change also updates all import statements across the application to reflect the new location of these components. The `BitwardenOutlinedButton` within the `authenticator` module has been removed, as the `ui` module's version will now be used.
SaintPatrck
changed the title
SaintPatrck
commented
May 21, 2025
| * Colors for a [BitwardenOutlinedButton]. | ||
| */ | ||
| @Immutable | ||
| data class BitwardenOutlinedButtonColors( |
There was a problem hiding this comment.
This is not new. It was extracted from BitwardenOutlinedButton. It seemed out of place embedded in BitwardenOutlinedButton.
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ui-module/bitwarden-icon-buttons #5242 +/- ##
====================================================================
+ Coverage 82.49% 82.57% +0.07%
====================================================================
Files 693 688 -5
Lines 51381 51176 -205
Branches 6932 6932
====================================================================
- Hits 42389 42258 -131
+ Misses 6685 6611 -74
Partials 2307 2307 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SaintPatrck
force-pushed
the
ui-module/bitwarden-icon-buttons
branch
from
67e9bbf to
2022ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-21891
📔 Objective
This commit moves the
BitwardenOutlinedButtoncomposable and its associatedBitwardenOutlinedButtonColorsdata class from theappmodule to theuimodule.This change also updates all import statements across the application to reflect the new location of these components.
The
BitwardenOutlinedButtonwithin theauthenticatormodule has been removed, as theuimodule's version will now be used.Important
There is a visual change as a direct result of this migration. See the screenshot below.
📸 Screeshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes