Skip to content

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Apr 15, 2025

๐ŸŽŸ๏ธ Tracking

TBD

๐Ÿ“” Objective

Added support for the Basque language to the app.

๐Ÿ“ธ Screenshots

image

image

image

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Added support for the Basque language to the app.
@SaintPatrck SaintPatrck added the hold do not merge yet label Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 83.90%. Comparing base (18c7333) to head (1cc4aa4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5059   +/-   ##
=======================================
  Coverage   83.90%   83.90%           
=======================================
  Files         596      596           
  Lines       48460    48460           
  Branches     6680     6680           
=======================================
  Hits        40659    40659           
  Misses       5533     5533           
  Partials     2268     2268           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 8f63d855-b50c-4f0f-9626-7a3deb2118df

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold do not merge yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant