[PM-13789] add credential manager provider for passwords #4110

Nailik · 2024-10-17T16:16:00Z

🎟️ Tracking

📔 Objective

Currently there is only an implementation to provide or save Fido2 credentials via the CredentialManager.
The objective is to add the possibility to save and create Passwords.

Credential Manager usage: https://developer.android.com/identity/sign-in/credential-manager
Credential Provider to provide Credential Manager: https://developer.android.com/identity/sign-in/credential-provider
Example Project: https://github.com/android/identity-samples/tree/main/CredentialManager

Status

new BitwardenCredentialProviderService to handle incoming credential requests
new CredentialCompletionManager (from Fido2CompletionManager) to handle both passkeys and passwords
Overwrite Password/Username combination confirmation dialogs.

Working on:

Cleanup (formatting, comments etc)
fixing tests / adding tests

Found issues:

showFido2ErrorDialog doesn't always show the correct reason, however to stay consistent the showPaswordErrorDialog also shows always the same issue

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

CLAassistant · 2024-10-17T16:16:06Z

All committers have signed the CLA.

bitwarden-bot · 2024-10-17T16:16:56Z

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-13789

Nailik · 2024-10-21T20:53:46Z

I would like a check/pre-review from the code owners before starting to work on the tests.

Maybe this could be split into multiple smaller PRs as it got already a lot bigger than i thought it would be - and it's also a lot to review

Nailik · 2025-01-17T16:34:00Z

due to a lot of changes in the types it's currently not compiling

however i am not sure if i just waste my time here since i get no response or any info if this feature is planned ...

SaintPatrck · 2025-01-21T15:05:38Z

Hi @Nailik

Apologies for the late response. We've been busy shoring up our native releases. We are interested in consuming these changes and do appreciate you taking the time to submit them.

As you stated, there has been refactoring that conflicts with the changes you submitted. There's potential for more refactoring once Google releases the next version of Credential Manager (1.5.0). I suggest holding this PR until the new CredMan library is available. As soon as time permits we will review and provide feedback.

Nailik · 2025-01-21T15:06:55Z

@SaintPatrck perfect thank you.

Nailik · 2025-03-25T16:50:43Z

androidx.credentials:credentials:1.5.0 was released on 15. Mar so i will resume working on this PR now.
Will take some time

SaintPatrck · 2025-03-26T16:35:25Z

androidx.credentials:1.5.0 introduces breaking changes. I suggest holding off until we have properly refactored to accommodate the changes (see WIP #4919).

Nailik · 2025-03-26T16:42:30Z

thx for letting me know

Nailik · 2025-05-12T16:41:41Z

I am currently rewriting the whole PR.

Currently i am blocked because of an issue with #5101.

SaintPatrck · 2025-05-12T21:10:36Z

Hi @Nailik

I'm glad to see you're still willing to pick this back up! It's very much appreciated. 🫶

You may want to build on #5177 since it includes changes that will make implementing password credentials a little cleaner.

…universal Credential intent and functions

…le password requests

… intent

...c/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt

…ider

…nager-provider

…tication

…ider # Conflicts: # app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt # app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt # app/src/test/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerTest.kt # app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt # app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt

Nailik · 2025-07-23T09:33:25Z

hi i just fixed the conflicts, would be nice if we can get this merged, it's really getting harder to fix the conflicts with main when there are refactorings that don't take into account that not every credential operation is about passkeys

…in order to make more clear it's only used for fido2/passkeys

SaintPatrck · 2025-07-23T18:19:41Z

...c/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt

+    ): List<CredentialEntry> {
+        if (this.isEmpty()) return emptyList()
+
+        val ciphers = autofillCipherProvider


We can't utilize autofillCipherProvider in its current state because it omits ciphers that we want included in the CredentialManager results. In this case, ciphers that require reprompt are being omitted. During the CredentialManager flow we can prompt for master password, so we should be including them in the results.

SaintPatrck · 2025-07-23T18:22:59Z

@Nailik Thanks for staying on top of the updates. In order to relieve some of your burden, I can update the failing tests and make a few other tweaks to accommodate the recent changes I introduced. My hope is to get this PR merged by end of week. 🤞

…nager This commit refactors `BitwardenCredentialManagerImpl` and its tests to utilize `CipherListView` objects directly for credential retrieval and matching, instead of relying on `AutofillCipherProvider`. Key changes: - `BitwardenCredentialManagerImpl` now uses `CipherMatchingManager` to filter `CipherListViews` based on the calling app's package name. - The `getCredentialEntries` method in `BitwardenCredentialManagerImpl` has been updated to fetch and filter `CipherListViews` from `VaultRepository`. - `CredentialEntryBuilder` and its implementation now accept `List<CipherListView>` instead of `List<AutofillCipher.Login>` for building password credential entries. - The `AutofillCipherProvider` dependency has been removed from `BitwardenCredentialManagerImpl` and `CredentialProviderModule`. - Introduced `isActiveWithCopyablePassword` extension for `CipherListView`. - Tests for `BitwardenCredentialManagerImpl`, `CredentialEntryBuilderTest`, and related ViewModels have been updated to reflect these changes, including mocking `CipherMatchingManager` and providing `CipherListView` instances. - Updated `createMockProviderGetPasswordCredentialRequest` to accept a number parameter for easier test data generation. - Minor adjustments in test helpers and mock object creation to align with the refactoring. - `VaultItemListingViewModel` now checks `CipherListView.reprompt` before fetching the full `CipherView` for password credential requests. An error is now sent if the `CipherListView` is not found.

SaintPatrck · 2025-07-24T13:30:18Z

@Nailik we're ready to merge the changes, but the CLA is giving us pause. Is kilian.eller a handle of yours? If so, are you able to associate the corresponding email address with your GitHub account to satisfy the CLA agent?

…ider

Nailik requested review from a team, ahaisting-livefront, brian-livefront, david-livefront and dseverns-livefront as code owners October 17, 2024 16:16

bitwarden-bot changed the title ~~[DRAFT] add credential manager provider for passwords~~ [PM-13789] [DRAFT] add credential manager provider for passwords Oct 17, 2024

bitwarden-bot added the community-pr label Oct 17, 2024

Nailik force-pushed the feature/add-password-credential-manager-provider branch 3 times, most recently from 4aa9f5a to 5a6e528 Compare October 20, 2024 01:03

Nailik changed the title ~~[PM-13789] [DRAFT] add credential manager provider for passwords~~ [PM-13789] add credential manager provider for passwords Oct 22, 2024

djsmith85 linked an issue Nov 11, 2024 that may be closed by this pull request

No Credential Manager Password Prompt #4100

Closed

2 tasks

Nailik requested a review from phil-livefront as a code owner January 17, 2025 16:32

Nailik added 6 commits May 27, 2025 15:36

add capability TYPE_PASSWORD_CREDENTIAL

c461136

handle BeginCreatePasswordCredentialRequest in CredentialProvider

2b54d9d

rename CredentialProvider Passkey/Fido2 intent and functions to more …

e45a839

…universal Credential intent and functions

remove filter BeginGetPublicKeyCredentialOption in order to also hand…

22b9a59

…le password requests

add feature flag SingleTapPasswordAuthentication

efb4ef7

split intent manager between fido2 credential and password credential…

b1e86cd

… intent

david-livefront reviewed Jul 3, 2025

View reviewed changes

...c/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt Outdated Show resolved Hide resolved

SaintPatrck and others added 12 commits July 15, 2025 10:07

Formatting

91ec07f

Merge branch 'main' into feature/add-password-credential-manager-prov…

22bd9cd

…ider

Merge branch 'main' into feature/add-password-credential-manager-prov…

4dfe0b2

…ider

Merge branch 'bitwarden:main' into feature/add-password-credential-ma…

31a44a0

…nager-provider

rename fido 2 verification functions to credential verification

21d8ebc

fix master password prompt and pin prompt for password request authen…

afc8b63

…tication

add new texts

adf599b

fix

ab6b06a

formatting

4e2634b

fix merge conflicts

0982668

formatting

b007785

remove wrong check and rename cipherListView to fido2CipherListViews …

cc56505

…in order to make more clear it's only used for fido2/passkeys

SaintPatrck reviewed Jul 23, 2025

View reviewed changes

SaintPatrck force-pushed the feature/add-password-credential-manager-provider branch from 1de00fc to 2c3c763 Compare July 23, 2025 19:42

SaintPatrck force-pushed the feature/add-password-credential-manager-provider branch from 2c3c763 to 48c49a0 Compare July 23, 2025 19:48

david-livefront approved these changes Jul 23, 2025

View reviewed changes

Merge branch 'main' into feature/add-password-credential-manager-prov…

0e317f1

…ider

SaintPatrck approved these changes Jul 24, 2025

View reviewed changes

SaintPatrck added this pull request to the merge queue Jul 24, 2025

Merged via the queue into bitwarden:main with commit 355facc Jul 24, 2025
11 of 12 checks passed

Nailik deleted the feature/add-password-credential-manager-provider branch July 24, 2025 21:03

Nailik mentioned this pull request Jul 24, 2025

[PM-24148] add credential manager provider for create passwords #5579

Merged

Jiejd mentioned this pull request Oct 10, 2025

[PM-26002] Bug: Bitwarden Passkey Not Found After Website Refresh (Android 15, Edge/Chrome Browsers) #5911

Closed

3 tasks

[PM-13789] add credential manager provider for passwords #4110

[PM-13789] add credential manager provider for passwords #4110

Uh oh!

Conversation

Nailik commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎟️ Tracking

📔 Objective

Status

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

Uh oh!

CLAassistant commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bitwarden-bot commented Oct 17, 2024

Uh oh!

Nailik commented Oct 21, 2024

Uh oh!

Nailik commented Jan 17, 2025

Uh oh!

SaintPatrck commented Jan 21, 2025

Uh oh!

Nailik commented Jan 21, 2025

Uh oh!

Nailik commented Mar 25, 2025

Uh oh!

SaintPatrck commented Mar 26, 2025

Uh oh!

Nailik commented Mar 26, 2025

Uh oh!

Nailik commented May 12, 2025

Uh oh!

SaintPatrck commented May 12, 2025

Uh oh!

Uh oh!

Nailik commented Jul 23, 2025

Uh oh!

SaintPatrck Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

SaintPatrck commented Jul 23, 2025

Uh oh!

SaintPatrck commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Nailik commented Oct 17, 2024 •

edited

Loading

CLAassistant commented Oct 17, 2024 •

edited

Loading