feat: pre-bundle iOS lighttpd server as xcframework #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1558444.
Owner
|
Hey @simoneldevig , I just wanna say thanks for you PR, and confirm I have seen it; though, I am not sure when I'll get around to merge it in — I don't have a previous experience with doing the stuff you did in this PR, thus it is difficult for me to find time & motivation to understand and verify it, and at the same time I am afraid to open a Pandora box by merging it in — in case it has any undesirable side-effects that will need further work to address. |
birdofpreyru
added
P2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Pre-bundle iOS lighttpd server as xcframework
The
cmakedependency makes it challenging to integrate the package into codebases with many developers, as everyone needs to havecmakeset up, including the CI.I've therefore added an Xcode project and scripts to prebuild the
lighttpddependency and bundle it as an xcframework.Only downside here is that the
mod_webdavcan no longer be optional for iOS.