Skip to content

[FIX] Add emg to timeseries rule for physio/stim files#2346

Merged
effigies merged 2 commits intobids-standard:masterfrom
neuromechanist:fix-emg-physio-timeseries
Feb 19, 2026
Merged

[FIX] Add emg to timeseries rule for physio/stim files#2346
effigies merged 2 commits intobids-standard:masterfrom
neuromechanist:fix-emg-physio-timeseries

Conversation

@neuromechanist
Copy link
Member

@neuromechanist neuromechanist commented Feb 14, 2026

Summary

  • Add emg to the base timeseries rule datatypes in src/schema/rules/files/raw/task.yaml
  • This allows _physio, _physioevents, and _stim suffixes to be valid within emg/ directories
  • EMG was the only datatype missing from the timeseries rule, despite being a first-class BIDS datatype since v1.11.0 (BEP 042)

Context

When converting the HySER dataset to BIDS-EMG format, finger force sensor recordings (_physio.tsv.gz) placed alongside EMG data cause ALL_FILENAME_RULES_HAVE_ISSUES validation errors because the validator schema does not include emg in the timeseries rule.

All other electrophysiology datatypes (eeg, ieeg, nirs) as well as beh, func, meg, motion, pet, anat, dwi, and perf already support physio/stim files.

Test plan

  • Verify emg is a defined datatype in src/schema/objects/datatypes.yaml
  • Run schema tests
  • Validate a BIDS-EMG dataset with _physio.tsv.gz files passes after this change

The timeseries rule defines which datatypes support _physio,
_physioevents, and _stim suffixes. EMG was missing from this
list, causing validation errors for datasets with physiological
recordings (e.g., force sensor data) alongside EMG data.
@neuromechanist neuromechanist added bug Something isn't working EMG exclude-from-changelog This item will not feature in the automatically generated changelog labels Feb 14, 2026
@neuromechanist neuromechanist changed the title Add emg to timeseries rule for physio/stim files [FIX] Add emg to timeseries rule for physio/stim files Feb 14, 2026
@effigies
Copy link
Collaborator

effigies commented Feb 16, 2026

I agree with this. A question is whether this should wait on (or justify) another BIDS release (1.11.1) or can be a schema patch (schema-1.2.1) on v1.11.0.

For it to be a schema patch, it cannot change the semantic meaning of the BIDS specification version 1.11.0. While I think this was obviously intended in v1.11.0, it does change the literal text of the document, so I think a stickler could argue for a new spec release.

There has been very little activity since the 1.11.0 release, so we could simply make a 1.11.1 release with this fix, and avoid the whole question.

Opinions? @bids-standard/maintainers @bids-standard/steering?


Edit: Per discussion with BIDS maintainers, we will release a 1.11.1 without the usual 1 week notice, as the change is so small.

@effigies effigies removed the exclude-from-changelog This item will not feature in the automatically generated changelog label Feb 19, 2026
@effigies
Copy link
Collaborator

@neuromechanist Could you add a physio file to an example dataset to validate this?

Copy link
Collaborator

@bendhouseart bendhouseart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@effigies effigies merged commit 14c3b8e into bids-standard:master Feb 19, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working EMG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants