[FIX] Add emg to timeseries rule for physio/stim files#2346
[FIX] Add emg to timeseries rule for physio/stim files#2346effigies merged 2 commits intobids-standard:masterfrom
Conversation
The timeseries rule defines which datatypes support _physio, _physioevents, and _stim suffixes. EMG was missing from this list, causing validation errors for datasets with physiological recordings (e.g., force sensor data) alongside EMG data.
|
I agree with this. A question is whether this should wait on (or justify) another BIDS release ( For it to be a schema patch, it cannot change the semantic meaning of the BIDS specification version 1.11.0. While I think this was obviously intended in v1.11.0, it does change the literal text of the document, so I think a stickler could argue for a new spec release. There has been very little activity since the 1.11.0 release, so we could simply make a 1.11.1 release with this fix, and avoid the whole question. Opinions? @bids-standard/maintainers @bids-standard/steering? Edit: Per discussion with BIDS maintainers, we will release a 1.11.1 without the usual 1 week notice, as the change is so small. |
|
@neuromechanist Could you add a physio file to an example dataset to validate this? |
Summary
emgto the basetimeseriesrule datatypes insrc/schema/rules/files/raw/task.yaml_physio,_physioevents, and_stimsuffixes to be valid withinemg/directoriesContext
When converting the HySER dataset to BIDS-EMG format, finger force sensor recordings (
_physio.tsv.gz) placed alongside EMG data causeALL_FILENAME_RULES_HAVE_ISSUESvalidation errors because the validator schema does not includeemgin the timeseries rule.All other electrophysiology datatypes (
eeg,ieeg,nirs) as well asbeh,func,meg,motion,pet,anat,dwi, andperfalready support physio/stim files.Test plan
emgis a defined datatype insrc/schema/objects/datatypes.yaml_physio.tsv.gzfiles passes after this change