Add and use Lucide icon font #190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Apr 30, 2025
|
Poke @chompaa; I may need you to help me get this past CI. |
|
Will take a look tomorrow, thanks for the poke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45.
I took the liberty to add the new icons in two places. I also thought about potentially auto-generating all of the icons, but it seemed excessive. Perhaps we should cherry-pick some (maybe from the Figma).
We can also remove the SVGs used in the asset browser now, but I haven't done that in this PR.
It wasn't clear to me what the icon next to the panel header should be, but the code refers to it being a potential dropdown so I chose the chevron.