-
Notifications
You must be signed in to change notification settings - Fork 85
Amélioration des composants de type Fields #3637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
newick
wants to merge
17
commits into
feat/comparateur_location_meuble
Choose a base branch
from
a11y/composants-fields
base: feat/comparateur_location_meuble
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de location de meublé
… location de logement de courte durée
…e l’engine Publicodes
…s nouvelles cotisations hybrides
…icodes) sur une simulation
Refactoring majeur pour découpler les composants UI de la logique Publicodes : - Remplace les props spreads ({...commonProps}) dans RuleInput par des props explicitement nommées - Clarifie les dépendances réelles entre composants - Rend visible les props effectivement utilisées par chaque composant - Remplace les interfaces de props héritées par des interfaces explicites et auto-documentées - Supprime la dépendance à InputProps partout - Extrait les composants UI dans le design-system et crée des stories - Définit explicitement les props pertinentes pour chaque composant
…s questionRegimeCotisation.tsx
…ants de saisie - Remplace QuestionEnCours et Conversation par un système modulaire avec QuestionFournie - Ajoute des adaptateurs pour les types Montant et OuiNon - Restructure les composants de saisie pour une meilleure réutilisabilité - Découplage, découplage, découplage
…l’économie collaborative qui ne sont plus utilisés, et ne fonctionnent pas (régime TI et ME)
🚀 La branche est déployée !
|
@newick c’est un draft parce qu’il te reste un truc à faire ? |
d67db96
to
977d3d0
Compare
@JalilArfaoui c'est en Draft parce que je pensais qu'on pouvait résoudre #3628, #3627 et #3626 dedans. |
928ad4d
to
c5f7d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
À partir des éléments mis dans Storybook dans #3459, amélioration des éléments suivants