Update Makefile

[dobby33]

After enabling CONFIG_WIN32 at line 35 in Makefile, command make still failing with such message:

C:/w64devkit/bin/ld.exe: cannot find -ldl: No such file or directory

[nickva]

I had never tried w64devkit but on windows I compile it with Msys2 like in the CI step:

quickjs/.github/workflows/ci.yml

Lines 244 to 250 in 638ec8c

	with:
	msystem: UCRT64
	update: true
	install: git make mingw-w64-ucrt-x86_64-gcc mingw-w64-ucrt-x86_64-dlfcn
	- name: Build
	run: |
	make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y

Another alternative is to cross-compile on Linux for Windows:

quickjs/.github/workflows/ci.yml

Lines 215 to 229 in 638ec8c

	- name: Install MinGW and Wine
	run: |
	sudo apt install -y wine mingw-w64
	cp /usr/x86_64-w64-mingw32/lib/libwinpthread-1.dll .
	- name: Setup Wine
	run: |
	wine --version
	winecfg /v
	# binfmt doesn't work in GitHub Actions
	#sudo apt install -y binfmt-support wine-binfmt
	#echo ":Wine:M::MZ::/usr/bin/wine:" > /etc/binfmt.d/wine.conf
	#sudo systemctl restart systemd-binfmt
	- name: Build
	run: |
	make CONFIG_WIN32=y

[dobby33]

ld --version
GNU ld (GNU Binutils) 2.44

echo $W64DEVKIT
2.2.0

According to

quickjs/.github/workflows/ci.yml

Line 250 in 638ec8c

make -j$(getconf _NPROCESSORS_ONLN) CONFIG_WERROR=y

variable CONFIG_WIN32 didn't applied.

According to

quickjs/.github/workflows/ci.yml

Line 208 in 638ec8c

runs-on: ubuntu-latest

assuming

quickjs/.github/workflows/ci.yml

Line 229 in 638ec8c

make CONFIG_WIN32=y

ran under Linux where -ldl parameter make sense.

[nickva]

In the msys2 environment on windows the mingw-w64-ucrt-x86_64-dlfcn package provides the runtime dynamic library loading. It's a separate package that has to be installed.

[dobby33]

In the msys2 environment on windows the mingw-w64-ucrt-x86_64-dlfcn package provides the runtime dynamic library loading. It's a separate package that has to be installed.

I suspected that this was the case.

Although my assumption was incorrect. Using MSYS2 does apply CONFIG_WIN32.

quickjs/Makefile

Lines 88 to 89 in 638ec8c

	else ifdef MSYSTEM
	CONFIG_WIN32=y