Skip to content

Conversation

@AMEIJER1
Copy link
Collaborator

@AMEIJER1 AMEIJER1 commented Aug 7, 2025

Description of Changes

  • added a uuid column to the observation subcount table
  • dropped subcount critter table and the models and services and repositories associated with it
  • rendered front end animal selection in the subcount form
  • edited post requests to include critterbase critter id
  • observation table container and spatial table both have observed animal columns now displaying alias
  • added a control so that if an animal is selected, the count is automatically 1 and cannot be overwritten

Testing Notes

    • should the front-end critter selector in the form also display critter id, not just alias. since it is all animals users have access to, what if there are multiples with the same name?

@AMEIJER1 AMEIJER1 self-assigned this Aug 7, 2025
@AMEIJER1 AMEIJER1 added Do Not Merge PR should not be merged Not Ready For Review Addressing feedback and/or refactoring labels Aug 7, 2025
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 1.18110% with 251 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.93%. Comparing base (21118f7) to head (ed4df9c).

Files with missing lines Patch % Lines
...ts/subcount/critter/SubcountCritterSelectField.tsx 0.00% 90 Missing ⚠️
...ents/observation/SurveySpatialObservationTable.tsx 0.00% 54 Missing ⚠️
app/src/contexts/observationsTableContext.tsx 4.44% 43 Missing ⚠️
...orm/components/subcounts/subcount/SubcountForm.tsx 0.00% 24 Missing ⚠️
...ts/subcounts/subcount/count/SubcountCountField.tsx 0.00% 19 Missing ⚠️
.../grid-column-definitions/GridColumnDefinitions.tsx 0.00% 14 Missing ⚠️
...rvices/observation-services/observation-service.ts 0.00% 2 Missing ⚠️
...ations/form/components/subcounts/SubcountsForm.tsx 0.00% 1 Missing ⚠️
...ys/observations/form/components/subcounts/utils.ts 0.00% 1 Missing ⚠️
...observations/form/create/CreateObservationPage.tsx 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1571      +/-   ##
==========================================
- Coverage   33.07%   32.93%   -0.14%     
==========================================
  Files        1033     1031       -2     
  Lines       65168    65392     +224     
  Branches     2357     2358       +1     
==========================================
- Hits        21553    21538      -15     
- Misses      43075    43314     +239     
  Partials      540      540              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@AMEIJER1 AMEIJER1 added Ready For Review PR is ready for review and removed Do Not Merge PR should not be merged Not Ready For Review Addressing feedback and/or refactoring labels Aug 11, 2025
@dylanrogowsky-oxd dylanrogowsky-oxd force-pushed the dev branch 3 times, most recently from 1ff7b4d to 7e78a28 Compare September 16, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready For Review PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants