Expose CRDT update without key delegating key generation to Riak #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional key in request and Riak-generated key are [documented already](https://github.com/basho/basho_docs/blob/814125935ca55a5801764dcb780534a89b599dec/content/riak/kv/2.2.0/developing/api/protocol-buffers/dt-store.md#optional-parameters). PB encoder [already has type spec](https://github.com/basho/riak_pb/blob/4198223ec788401da5cbf2868e3181b6b5db289a/src/riak_pb_dt_codec.erl#L490-L494) catering for optional key.
This was referenced Feb 20, 2017
Contributor
|
Thanks! |
Author
|
@lukebakken When will a new riakc tag be taken? I have a Dialyzer warning in another project that I understand needs this change in a tag (and packaged in Hex) in order to be fixed. |
lukebakken
added a commit
that referenced
this pull request
Mar 2, 2017
Port PR 351 to release-2.5.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed no Dialyzer warnings less or more with this change.
I did not run the test locally - relying on bot to do that.