Implement errors for listing operations. #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmoore
suggested changes
Feb 9, 2017
Contributor
alexmoore
left a comment
alexmoore
left a comment
There was a problem hiding this comment.
Looks pretty good. We can add the MR check here I think:
riak-erlang-client/src/riakc_pb_socket.erl
Line 828 in 7369e45
Contributor
Author
|
@alexmoore I'll dig into that because MR inputs can be several different things ... a bucket name, bucket/bucket type combo, or a list of "locations" (bt/b/key tuples) |
alexmoore
approved these changes
Feb 14, 2017
Contributor
|
Looks good, +1. We've got some dialyzer errors too, but I think it's not related to your changes - we just need to enable them for Travis so we can see them again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code to return error when listing objects unless the
allow_listingoption is true.Fixes #345 (CLIENTS-1067) (CLIENTS-1067) (CLIENTS-1067) and
CLIENTS-1067