[Ready for review] Use default CPU resources when GPU type is None #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeepak-baseten
changed the title
| @@ -284,6 +284,10 @@ def _get_compute(compute: Optional[Compute]) -> Compute: | |||
| if not compute: | |||
| compute = Compute(cpu_count=0, memory="0Mi") | |||
| compute.accelerator = _get_accelerator_if_specified(compute.accelerator) | |||
| # User did not specify an accelerator, so we default to CPU. | |||
| if not compute.accelerator: | |||
There was a problem hiding this comment.
is this going to overwrite the compute provided by the customer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review.
🚀 What
When user specifies GPU type as "None", use default CPU count and memory size. Without this, truss sends "0" CPU and "0 MB" memory, causing deployment to fail with insufficient resources.
💻 How
Add code to set CPU count and memory, if accelerator is not specified.
🔬 Testing
Add mock for CPU config, add test