bump node package chrome-launcher#197
Open
christovic wants to merge 1 commit intobalena-io-experimental:masterfrom
Open
bump node package chrome-launcher#197christovic wants to merge 1 commit intobalena-io-experimental:masterfrom
christovic wants to merge 1 commit intobalena-io-experimental:masterfrom
Conversation
Contributor
|
A repository maintainer needs to approve these workflow run(s). To approve, maintainers can either: • Submit an approval review on this pull request, OR • Submit a review comment starting with Then re-run the failed job(s) via the Checks tab above. Reviews must be on the specific commit SHA of the workflow run to be considered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found that we weren't able to stop the Translate UI from popping up. That's because
chrome-launchersets--disable-features=TranslateUI, which was deprecated and replaced with justTranslateback in 2020.chrome-launcherwas updated 3 years ago to support this change.I couldn't see any breaking changes in the release notes, and tested this in a virtual machine.
Worth noting it seems some other flags have changed.
New flags added:
Flags changed:
Before:
After:
Nearly impossible to tell whether some users of this block would be affected by these changes. We could add
--disable-featuresto the filter here if we wanted to set this manually.Most of the new flags that have been added seem sensible though.