Skip to content

bump node package chrome-launcher#197

Open
christovic wants to merge 1 commit intobalena-io-experimental:masterfrom
christovic:bump-chrome-launcher
Open

bump node package chrome-launcher#197
christovic wants to merge 1 commit intobalena-io-experimental:masterfrom
christovic:bump-chrome-launcher

Conversation

@christovic
Copy link
Copy Markdown

@christovic christovic commented Nov 20, 2025

Found that we weren't able to stop the Translate UI from popping up. That's because chrome-launcher sets --disable-features=TranslateUI, which was deprecated and replaced with just Translate back in 2020.

chrome-launcher was updated 3 years ago to support this change.

I couldn't see any breaking changes in the release notes, and tested this in a virtual machine.

Worth noting it seems some other flags have changed.

New flags added:

--disable-hang-monitor
--disable-prompt-on-repost
--disable-domain-reliability
--propagate-iph-for-testing
--disable-ipc-flooding-protection
--password-store=basic
--use-mock-keychain
--disable-component-update
--disable-client-side-phishing-detection

Flags changed:
Before:

--disable-features=TranslateUI

After:

--disable-features=Translate,OptimizationHints,MediaRouter,DialMediaRouteProvider,CalculateNativeWinOcclusion,InterestFeedContentSuggestions,CertificateTransparencyComponentUpdater,AutofillServerCommunication,PrivacySandboxSettings4,RenderDocument

Nearly impossible to tell whether some users of this block would be affected by these changes. We could add --disable-features to the filter here if we wanted to set this manually.

Most of the new flags that have been added seem sensible though.

@flowzone-app
Copy link
Copy Markdown
Contributor

flowzone-app bot commented Nov 20, 2025

A repository maintainer needs to approve these workflow run(s).

To approve, maintainers can either:

Submit an approval review on this pull request, OR

Submit a review comment starting with /deploy

Then re-run the failed job(s) via the Checks tab above.

Reviews must be on the specific commit SHA of the workflow run to be considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant