/usr/bin/entry.sh is executed twice#162
Open
kohnw wants to merge 1 commit intobalena-io-experimental:masterfrom
Open
/usr/bin/entry.sh is executed twice#162kohnw wants to merge 1 commit intobalena-io-experimental:masterfrom
kohnw wants to merge 1 commit intobalena-io-experimental:masterfrom
Conversation
…rypoint..." from /usr/src/app/start.sh as this /usr/bin/entry.sh is already being run as an entrypoint by Dockerfile and thus it was being run twice and udev deamon as well twice, which is wrong...
Author
|
Is there anything which i can do to proceed with this merge request? |
Contributor
|
Hi @kohnw - thank you for the nudge! I'm really sorry, I was trying to push this along and got distracted, many many times. :) You need to edit your commit so that the commit message includes a Change-type. You can see an example of this on this PR. Flowzone requires this so that it can bump the semver in the correct way. Phil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we removed line /usr/bin/entry.sh echo "Running balena base image entrypoint..." from /usr/src/app/start.sh as this /usr/bin/entry.sh is already being run as an entrypoint by Dockerfile and thus it was being run twice and udev deamon as well twice, which is wrong...
Running two udev daemons caused issues with reconnecting USB devices.