Update google-protobuf dependency #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates the google-protobuf dependency from version 3.x to 4.x due to end-of-life support, replacing the deprecated descriptor DSL approach with protoc-compiled protobuf files as version 4.x no longer supports runtime compilation of protobuf descriptors.
- Switches from runtime protobuf compilation to protoc-generated files
- Updates google-protobuf dependency from ~> 3 to ~> 4
- Adds Makefile target for regenerating protobuf files
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| proto/kinesis_aggregation.proto | Adds new protobuf definition file for Kinesis aggregation format |
| lib/fluent/plugin/kinesis_helper/aggregator.rb | Removes inline protobuf DSL and imports generated protobuf classes |
| lib/fluent/plugin/gen/kinesis_aggregation_pb.rb | Auto-generated protobuf Ruby classes from proto definition |
| fluent-plugin-kinesis.gemspec | Updates google-protobuf dependency from ~> 3 to ~> 4 |
| Makefile | Adds regenerate-protobuf target for protoc compilation |
simukappu
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #230
Description of changes:
Google-protobuf dependency version 3.x reached end of life.
This PR switch to protoc compiled protobufs as version 4.x dropped support for by code compiled protobuf (descriptor DSL file was dropped) and also switches google-protobuf dependency to version 4.x.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.