-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Support intrinsic functions capacity provider vpc config nstance requirements list properties #3869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vicheey
merged 4 commits into
develop
from
support-intrinsic-functions-CapacityProvider-VpcConfig-nstanceRequirements-list-properties
Jan 8, 2026
Merged
+526
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stanceRequirements list properties Update schema to allow both arrays and objects (for intrinsic functions) in list properties, and update corresponding test expectations.
89048f2 to
16ba761
Compare
bnusunny
requested changes
Jan 7, 2026
tests/translator/output/aws-cn/capacity_provider_with_intrinsics.json
Outdated
Show resolved
Hide resolved
tests/translator/output/aws-cn/capacity_provider_with_intrinsics.json
Outdated
Show resolved
Hide resolved
tests/translator/output/aws-us-gov/capacity_provider_with_intrinsics.json
Outdated
Show resolved
Hide resolved
tests/translator/output/aws-us-gov/capacity_provider_with_intrinsics.json
Outdated
Show resolved
Hide resolved
…der-VpcConfig-nstanceRequirements-list-properties
Vandita2020
reviewed
Jan 7, 2026
samtranslator/internal/schema_source/aws_serverless_capacity_provider.py
Outdated
Show resolved
Hide resolved
Vandita2020
reviewed
Jan 7, 2026
tests/translator/output/aws-us-gov/capacity_provider_with_intrinsics.json
Show resolved
Hide resolved
Vandita2020
reviewed
Jan 7, 2026
bnusunny
approved these changes
Jan 8, 2026
Vandita2020
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The CapacityProvider schema was too restrictive for list properties when using CloudFormation intrinsic functions, so we updated the schema to support both direct arrays and intrinsic function objects.
Schema validation tests were failing when using intrinsic functions like
!Reffor list properties inCapacityProviderresources.Description of changes
aws_serverless_capacity_provider.pyschema to wrap list properties withSamIntrinsicableto support both arrays and intrinsic function objectssam.schema.jsonandschema.json) to reflect the updated Python schemaerror_capacity_provider_multiple_resources_validation.jsonto match new validation error messages that now say "value must be dictionary or list" instead of "value is not a valid list"Before (not supported):
After (now supported):
Description of how you validated change
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.