Enabling metrics via service-monitor for vpc-cni#1134
Open
yuvraj9 wants to merge 3 commits intoaws:masterfrom
Open
Enabling metrics via service-monitor for vpc-cni#1134yuvraj9 wants to merge 3 commits intoaws:masterfrom
yuvraj9 wants to merge 3 commits intoaws:masterfrom
Conversation
Author
|
@jayanthvn is it possible to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Right now this chart doesn't provide a default service monitor and service for metrics. This PR will enable default service and service monitors for users.
Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
I ran helm template command and also installed this chart on my kubernetes cluster to test this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.