chore: upgrade setuptools & pin cmake #3152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
reviewed
May 23, 2025
building/lambda/Dockerfile
Outdated
| RUN pip3 install --upgrade urllib3==1.26.16 # temporary to avoid https://github.com/urllib3/urllib3/issues/2168 (TODO remove when the AL2 image updates to support OpenSSL 1.1.1+) | ||
| RUN pip3 install --upgrade six cython cmake hypothesis poetry | ||
| RUN pip3 install --upgrade six cython cmake==3.31.6 hypothesis poetry |
There was a problem hiding this comment.
Can you just add a TODO so we would remember it next time please?
jaidisido
approved these changes
May 23, 2025
kukushking
commented
May 23, 2025
building/lambda/Dockerfile
Outdated
| @@ -34,9 +34,14 @@ RUN ln -s /usr/bin/gcc10-ld /usr/bin/ld | |||
| FROM ${python_version} | |||
| COPY pyproject.toml poetry.lock ./ | |||
|
|
|||
| RUN pip3 install --upgrade pip wheel setuptools>=64 setuptools_scm>=8 | |||
| # Setuptools is a build dependency of arrow and runtime dependency of some of our dependencies. | |||
There was a problem hiding this comment.
poetry show setuptools
name : setuptools
version : 80.8.0
description : Easily download, build, install, upgrade, and uninstall Python packages
required by
- jupyterlab requires >=41.1.0
- pbr requires *
- redshift-connector requires *
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.