Skip to content

Add query-compatible protocol tests #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2025

Conversation

peterrsongg
Copy link
Contributor

Description

Motivation and Context

Testing

Dry run passes

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@dscpinheiro dscpinheiro requested a review from boblodgett June 27, 2025 22:22
Copy link
Contributor

@dscpinheiro dscpinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a general comment, but this PR would've been easier to review if there were multiple commits (e.g. one for the protocol tests generator and another for the actual generated changes).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to these tests? Did the Smithy team remove them? (I couldn't find the equivalent removals in the generator/TestServiceModels/ changes)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I added a new test-service called QueryCompatibleJsonRPC10. I didn't actually touch anything related to this QueryCompatible service that existed so I'm not sure how this got removed. This isn't something smithy related, I believe this is something we created manually https://github.com/aws/aws-sdk-net/tree/main/generator/TestServiceModels/aws-query-compatible

The one I added though is the shapes for the smithy protocol tests. I also think that since we are consuming the smity protocol tests for query-compatbile we probably don't need these ones. We also have custom unit tests from the SEP as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Looking at the changes commit by commit maybe it was the generator/ProtocolTestsGenerator/smithy-dotnet-codegen/src/main/java/software/amazon/smithy/dotnet/codegen/HttpProtocolTestGenerator.java file?

But no need to change it now, we should revisit these hand-written test services later.

@peterrsongg peterrsongg force-pushed the petesong/cw-protocol-tests branch from d19fa75 to de5b158 Compare June 30, 2025 19:04
@peterrsongg
Copy link
Contributor Author

More of a general comment, but this PR would've been easier to review if there were multiple commits (e.g. one for the protocol tests generator and another for the actual generated changes).

my bad i was in a hurry and didn't fix up the commits. I just fixed them up though to make it a bit easier.

@peterrsongg peterrsongg requested a review from dscpinheiro June 30, 2025 20:16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Looking at the changes commit by commit maybe it was the generator/ProtocolTestsGenerator/smithy-dotnet-codegen/src/main/java/software/amazon/smithy/dotnet/codegen/HttpProtocolTestGenerator.java file?

But no need to change it now, we should revisit these hand-written test services later.

@dscpinheiro dscpinheiro added the v4 label Jun 30, 2025
@peterrsongg peterrsongg merged commit 5e4c3fa into development Jun 30, 2025
3 checks passed
@dscpinheiro dscpinheiro deleted the petesong/cw-protocol-tests branch June 30, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants