-
Notifications
You must be signed in to change notification settings - Fork 867
Add query-compatible protocol tests #3896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a general comment, but this PR would've been easier to review if there were multiple commits (e.g. one for the protocol tests generator and another for the actual generated changes).
generator/.DevConfigs/08424ec7-251c-4c0e-afbe-dda1f0ae7757.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to these tests? Did the Smithy team remove them? (I couldn't find the equivalent removals in the generator/TestServiceModels/
changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I added a new test-service called QueryCompatibleJsonRPC10. I didn't actually touch anything related to this QueryCompatible
service that existed so I'm not sure how this got removed. This isn't something smithy related, I believe this is something we created manually https://github.com/aws/aws-sdk-net/tree/main/generator/TestServiceModels/aws-query-compatible
The one I added though is the shapes for the smithy protocol tests. I also think that since we are consuming the smity protocol tests for query-compatbile we probably don't need these ones. We also have custom unit tests from the SEP as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Looking at the changes commit by commit maybe it was the generator/ProtocolTestsGenerator/smithy-dotnet-codegen/src/main/java/software/amazon/smithy/dotnet/codegen/HttpProtocolTestGenerator.java
file?
But no need to change it now, we should revisit these hand-written test services later.
d19fa75
to
de5b158
Compare
my bad i was in a hurry and didn't fix up the commits. I just fixed them up though to make it a bit easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Looking at the changes commit by commit maybe it was the generator/ProtocolTestsGenerator/smithy-dotnet-codegen/src/main/java/software/amazon/smithy/dotnet/codegen/HttpProtocolTestGenerator.java
file?
But no need to change it now, we should revisit these hand-written test services later.
Description
Motivation and Context
Testing
Dry run passes
Screenshots (if appropriate)
Types of changes
Checklist
License