-
Notifications
You must be signed in to change notification settings - Fork 92
chore: update issue, PR, and discussion templates #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b587752
chore: update issue & discussion templates
dreamorosi 448c92c
chore: update PR template
dreamorosi a23dcf2
Update .github/PULL_REQUEST_TEMPLATE.md
phipag 614f257
Update .github/DISCUSSION_TEMPLATE/rfcs.yml
phipag 7f07d42
Update .github/DISCUSSION_TEMPLATE/rfcs.yml
phipag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
name: Feature request | ||
description: Suggest an idea for Powertools for AWS Lambda | ||
title: "Feature request: TITLE" | ||
labels: ["feature-request", "triage"] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: | | ||
Thank you for taking the time to suggest an idea to the Powertools for AWS Lambda (Java) project. | ||
- type: textarea | ||
id: problem | ||
attributes: | ||
label: Use case | ||
description: Please help us understand your use case or problem you're facing | ||
validations: | ||
required: true | ||
- type: textarea | ||
id: suggestion | ||
attributes: | ||
label: Solution/User Experience | ||
description: Please share what a good solution would look like to this use case | ||
validations: | ||
required: true | ||
- type: textarea | ||
id: alternatives | ||
attributes: | ||
label: Alternative solutions | ||
description: Please describe what alternative solutions to this use case, if any | ||
render: Markdown | ||
validations: | ||
required: false | ||
- type: checkboxes | ||
id: acknowledgment | ||
attributes: | ||
label: Acknowledgment | ||
options: | ||
- label: This feature request meets [Powertools for AWS Lambda (Java) Tenets](https://docs.powertools.aws.dev/lambda/java/latest/#tenets) | ||
required: true | ||
- label: Should this be considered in other Powertools for AWS Lambda languages? i.e. [Python](https://github.com/aws-powertools/powertools-lambda-python/), [TypeScript](https://github.com/aws-powertools/powertools-lambda-typescript/), and [.NET](https://github.com/aws-powertools/powertools-lambda-dotnet/) | ||
required: false | ||
- type: markdown | ||
attributes: | ||
value: | | ||
--- | ||
|
||
**Disclaimer**: After creating an issue, please wait until it is triaged and confirmed by a maintainer before implementing it. This will reduce amount of rework and the chance that a pull request gets rejected. | ||
- type: input | ||
id: notes | ||
attributes: | ||
label: Future readers | ||
description: Please not edit this field | ||
value: "Please react with 👍 and your use case to help us understand customer demand." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,28 @@ | ||
**Issue #, if available:** | ||
## Summary | ||
|
||
## Description of changes: | ||
### Changes | ||
|
||
<!--- One or two sentences as a summary of what's being changed --> | ||
> Please provide a summary of what's being changed | ||
|
||
**Checklist** | ||
<!-- What is this PR solving? Write a clear description or reference the issue(s) it addresses. --> | ||
|
||
<!--- Leave unchecked if your change doesn't seem to apply --> | ||
> Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed | ||
|
||
* [ ] [Meet tenets criteria](https://docs.powertools.aws.dev/lambda-java/#tenets) | ||
* [ ] Update tests | ||
* [ ] Update docs | ||
* [ ] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0/) | ||
**Issue number:** | ||
|
||
## Breaking change checklist | ||
<!------- | ||
Before creating the pull request, please make sure you do the following: | ||
|
||
<!--- Ignore if it's not a breaking change --> | ||
- Read the Contributing Guidelines at https://github.com/aws-powertools/powertools-lambda-java/blob/main/CONTRIBUTING.md#sending-a-pull-request | ||
- Check that there isn't already a PR that addresses the same issue. If you find a duplicate, please leave a comment under the existing PR so we can discuss how to move forward | ||
- Check that the change meets the project's tenets https://docs.powertools.aws.dev/lambda/typescript/java/#tenets | ||
- Add a PR title that follows the conventional commit semantics - https://www.conventionalcommits.org/en/v1.0.0/ | ||
phipag marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- If relevant, add tests that prove that the change is effective and works | ||
- Whenever relevant, make sure to comment functions/methods/types and make appropriate changes to the documentation | ||
-------> | ||
|
||
**RFC issue #**: | ||
|
||
* [ ] Migration process documented | ||
* [ ] Implement warnings (if it can live side by side) | ||
--- | ||
|
||
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. | ||
|
||
**Disclaimer**: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.