Feat(Storage)!: Add subpathStrategy in Storage Category #5192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahnandrew
changed the title
This was referenced Jul 24, 2024
hahnandrew
added
storage
hahnandrew
changed the title
hahnandrew
changed the title
hahnandrew
changed the title
hahnandrew
changed the title
hahnandrew
changed the title
hahnandrew
changed the title
hahnandrew
changed the title
hahnandrew
changed the title
hahnandrew
changed the title
Equartey
reviewed
Aug 5, 2024
| class S3ListResult extends StorageListResult<S3Item> { | ||
| /// {@macro storage.amplify_storage_s3.list_result} | ||
| S3ListResult( | ||
| super.excludedSubpaths, |
Contributor
There was a problem hiding this comment.
Q: wondering if this should be a named parameter, has this been discussed?
Contributor
Author
There was a problem hiding this comment.
good callout, updated
hahnandrew
force-pushed
the
feat/delimiter-category
branch
3 times, most recently
from
bc5a62f to
478dd9e
Compare
hahnandrew
force-pushed
the
feat/delimiter-category
branch
5 times, most recently
from
e209754 to
3b0d0e0
Compare
hahnandrew
force-pushed
the
feat/delimiter-category
branch
from
3b0d0e0 to
924eea1
Compare
Equartey
reviewed
Aug 14, 2024
Contributor
Equartey
left a comment
Equartey
left a comment
There was a problem hiding this comment.
Good work! Changes look good to me. Holding approval until we're ready to merge.
NikaHsn
reviewed
Aug 14, 2024
packages/amplify_core/lib/src/category/amplify_storage_category.dart
Outdated
Show resolved
Hide resolved
packages/amplify_core/lib/src/category/amplify_storage_category.dart
Outdated
Show resolved
Hide resolved
packages/storage/amplify_storage_s3_dart/lib/src/model/s3_list_result.dart
Outdated
Show resolved
Hide resolved
...rage/amplify_storage_s3_dart/lib/src/storage_s3_service/service/storage_s3_service_impl.dart
Outdated
Show resolved
Hide resolved
packages/amplify_core/lib/src/category/amplify_storage_category.dart
Outdated
Show resolved
Hide resolved
packages/storage/amplify_storage_s3_dart/lib/src/model/s3_list_result.dart
Outdated
Show resolved
Hide resolved
packages/amplify_core/lib/src/category/amplify_storage_category.dart
Outdated
Show resolved
Hide resolved
Better naming conventions, docstrings, chaning methods to use defaults instead of nullability Co-authored-by: NikaHsn <[email protected]>
Co-authored-by: NikaHsn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with aws-amplify/docs#7811
Description of changes:
S3PluginOptionsdelimiterandexcludedSubpathssubpathStrategyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.