Dismantling global config object from SDK V2 #14199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/amplify-category-hosting/lib/S3AndCloudFront/helpers/cloudfront-manager.js
Fixed
Show fixed
Hide fixed
packages/amplify-provider-awscloudformation/src/iterative-deployment/deployment-manager.ts
Fixed
Show fixed
Hide fixed
…rt, function or class Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… into sdk-migrations-0
- @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - amplify-dotnet-function-runtime-provider@2.1.5-sdk-v2-with-data-0.0 - @aws-amplify/amplify-dotnet-function-template-provider@2.7.5-sdk-v2-with-data-0.0 - [email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - amplify-java-function-runtime-provider@2.3.52-sdk-v2-with-data-0.0 - @aws-amplify/[email protected] - amplify-nodejs-function-runtime-provider@2.5.30-sdk-v2-with-data-0.0 - @aws-amplify/amplify-nodejs-function-template-provider@2.10.15-sdk-v2-with-data-0.0 - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - amplify-python-function-runtime-provider@2.4.52-sdk-v2-with-data-0.0 - [email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected]
… into sdk-migrations-0
…sh tagged release sdk-v2-with-data-0" This reverts commit 5c4c686.
packages/amplify-console-integration-tests/__tests__/consoleHosting.test.ts
Fixed
Show fixed
Hide fixed
packages/amplify-console-integration-tests/__tests__/consoleHosting.test.ts
Fixed
Show fixed
Hide fixed
packages/amplify-e2e-tests/src/__tests__/pr-previews-multi-env-1.test.ts
Fixed
Show fixed
Hide fixed
packages/amplify-e2e-tests/src/__tests__/pr-previews-multi-env-1.test.ts
Fixed
Show fixed
Hide fixed
sobolk
reviewed
Jun 6, 2025
packages/amplify-container-hosting/src/lib/ElasticContainer/file-uploader.js
Outdated
Show resolved
Hide resolved
sobolk
previously approved these changes
Jun 16, 2025
- @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - [email protected] - [email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected]
This reverts commit 53e00af.
7 tasks
svidgen
approved these changes
Jun 19, 2025
sobolk
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is in preparation of SDK V2 to V3 migrations changes (nothing has actually be migrated yet).
SDK V2 reaches end of life on September 8, 2025 and we must upgrade SDK to V3 before that happens: https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-javascript-v2/
SDK V2 has a global configuration object that can be used to store a configuration which is automatically loaded into all of the service objects that are created unless the service object specifies an alternate configuration when it is created.
This global configuration object does not exist in SDK V3 so this PR works to move all the work that used to be done by the global config object to each of the individual service objects.
The threshold for the size of all the binaries has also temporarily been raised.
Global Config must remain around for some Aurora DB utilities on the Data side, can be completely removed when the PR on the data side is merged and released.
Sibling PR in the data repo handles dismantling of the global config that data inherited from CLI: aws-amplify/amplify-category-api#3310
Description of how you validated changes
Did a combination of manual testing (ensured that proxies and credentials with Access Keys and Profiles works as well as add, push, and delete commands) and updating the current tests to ensure that they could work without the global sdk config.
Ensured that SSO credentials workaround still works:
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.