Skip to content

Conversation

@cadivus
Copy link

@cadivus cadivus commented Dec 17, 2025

Issue #, if available:
#3167

Description of changes:
This change makes the webview create a new session every time a new sign-in window gets launched. This way, a browser-session is not used for multiple Cognito sessions.

How did you test these changes?
I created a simple app for logging in with Cognito and a SAML provider.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cadivus cadivus requested a review from a team as a code owner December 17, 2025 17:39
@cadivus cadivus requested a review from mattcreaser December 17, 2025 17:39
@cadivus cadivus force-pushed the fix/3167_UserCancelledException-occurs-on-sign-in-after-sign-out branch from 1ccdc85 to f9960e8 Compare December 18, 2025 10:02
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.78%. Comparing base (694dac0) to head (f9960e8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3169   +/-   ##
=======================================
  Coverage   54.78%   54.78%           
=======================================
  Files        1048     1048           
  Lines       31329    31330    +1     
  Branches     4690     4691    +1     
=======================================
+ Hits        17163    17165    +2     
+ Misses      12357    12356    -1     
  Partials     1809     1809           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant