[flake8-simplify] fix handlers corner cases (SIM105)

[VascoSch92]

The PR addresses issue #18209.

[github-actions]

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+6 -6 violations, +0 -0 fixes in 2 projects; 53 projects unchanged)

apache/superset (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ superset/migrations/versions/2015-12-04_09-42_1a48a5411020_adding_slug_to_dash.py:35:5: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- superset/migrations/versions/2015-12-04_09-42_1a48a5411020_adding_slug_to_dash.py:35:5: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`

binary-husky/gpt_academic (+5 -5 violations, +0 -0 fixes)

+ crazy_functions/Latex_Function.py:76:5: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- crazy_functions/Latex_Function.py:76:5: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`
+ multi_language.py:363:9: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- multi_language.py:363:9: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`
+ request_llms/com_qwenapi.py:57:21: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- request_llms/com_qwenapi.py:57:21: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`
+ request_llms/oai_std_model_template.py:72:5: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- request_llms/oai_std_model_template.py:72:5: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`
+ toolbox.py:463:13: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- toolbox.py:463:13: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
SIM105	12	6	6	0	0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+6 -6 violations, +0 -0 fixes in 2 projects; 53 projects unchanged)

apache/superset (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ superset/migrations/versions/2015-12-04_09-42_1a48a5411020_adding_slug_to_dash.py:35:5: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- superset/migrations/versions/2015-12-04_09-42_1a48a5411020_adding_slug_to_dash.py:35:5: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`

binary-husky/gpt_academic (+5 -5 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ crazy_functions/Latex_Function.py:76:5: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- crazy_functions/Latex_Function.py:76:5: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`
+ multi_language.py:363:9: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- multi_language.py:363:9: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`
+ request_llms/com_qwenapi.py:57:21: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- request_llms/com_qwenapi.py:57:21: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`
+ request_llms/oai_std_model_template.py:72:5: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- request_llms/oai_std_model_template.py:72:5: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`
+ toolbox.py:463:13: SIM105 Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`pass`
- toolbox.py:463:13: SIM105 Use `contextlib.suppress(Exception)` instead of `try`-`except`-`pass`

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
SIM105	12	6	6	0	0

[dscorbett]

This won’t work if BaseException is shadowed. Here is an example of how to safely insert a builtin symbol:

ruff/crates/ruff_linter/src/rules/flake8_bugbear/rules/unreliable_callable_check.rs

Lines 78 to 82 in b35bf8a

	let (import_edit, binding) = checker.importer().get_or_import_builtin_symbol(
	"callable",
	expr.start(),
	checker.semantic(),
	)?;

[VascoSch92]

@ntBre I have a problem. How I could import more stuff at the same time? Do you have an example where it was made in another rule?

I'm asking because here I would like to import subprocess from contextlib and also BaseException

[MichaReiser]

Would this work

ruff/crates/ruff_linter/src/rules/ruff/rules/quadratic_list_summation.rs

Lines 105 to 115 in 9ae698f

	let (reduce_edit, reduce_binding) = checker.importer().get_or_import_symbol(
	&ImportRequest::import("functools", "reduce"),
	call.start(),
	checker.semantic(),
	)?;
	let (iadd_edit, iadd_binding) = checker.importer().get_or_import_symbol(
	&ImportRequest::import("operator", "iadd"),
	iterable.start(),
	checker.semantic(),
	)?;

[VascoSch92]

Hey,
thanks for the help.

I hope understood what you were asking ;-)

[dscorbett]

Is this condition correct when BaseException is shadowed and caught explicitly?

BaseException = ValueError
try:
    int("a")
except BaseException:
    pass

The fixed version should use suppress(BaseException), not suppress(builtins.BaseException).

[VascoSch92]

Good catch. No, it was't. I added a new test case and fix that

[VascoSch92]

It should be fine now