Skip to content

Conversation

@lukepatrick
Copy link
Contributor

@lukepatrick lukepatrick commented Dec 22, 2025

Updated metrics.md docs after reviewing alongside Datadog metrics - there is also a DD PR to update their docs/integrations here

This PR also updates the example grafana dashboard with more examples using more Argo CD metrics.

  • AppSet Stats
  • OCI Stats
  • Kubectl Stats

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@lukepatrick lukepatrick requested review from a team as code owners December 22, 2025 04:41
@bunnyshell
Copy link

bunnyshell bot commented Dec 22, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@lukepatrick lukepatrick changed the title feat(docs): Fix Metrics docs and enhance example dashboard with more metrics docs(metrics/dashboard): Fix Metrics docs and enhance example dashboard with more metrics Dec 22, 2025
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.62%. Comparing base (b543e18) to head (d814c1d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25772      +/-   ##
==========================================
- Coverage   62.63%   62.62%   -0.01%     
==========================================
  Files         353      353              
  Lines       50159    50159              
==========================================
- Hits        31416    31414       -2     
- Misses      15725    15727       +2     
  Partials     3018     3018              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant