-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(security): add X-Frame-Options header to prevent clickjacking #25760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(security): add X-Frame-Options header to prevent clickjacking #25760
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25760 +/- ##
==========================================
- Coverage 62.63% 62.61% -0.02%
==========================================
Files 353 353
Lines 50159 50160 +1
==========================================
- Hits 31416 31408 -8
- Misses 15725 15736 +11
+ Partials 3018 3016 -2 ☔ View full report in Codecov by Sentry. |
nitishfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you go and fix the lint checks please?
- Add X-Frame-Options: DENY header to Swagger UI responses - Prevents clickjacking attacks by blocking iframe embedding - Fixes argoproj#22877 Signed-off-by: Sapthagiri777 <[email protected]>
Signed-off-by: Sapthagiri777 <[email protected]>
Signed-off-by: Sapthagiri777 <[email protected]>
Signed-off-by: Sapthagiri777 <[email protected]>
6829f30 to
dcfa20e
Compare
|
“Hi @nitishfy , the lint issues and DCO are fixed, and all checks are green. Please let me know if anything else is needed.” |
Description
Add the
X-Frame-Options: DENYheader to Swagger UI responses to preventclickjacking attacks, as requested in #22877.
Changes
X-Frame-Options: DENYheader to Swagger UI responsesChecklist
(b) this is a bug fix, or (c) this does not need to be in the release notes.
Fixes #22877in the description to automatically close the associated issue.