Skip to content

Conversation

@Sapthagiri777
Copy link

Description

Add the X-Frame-Options: DENY header to Swagger UI responses to prevent
clickjacking attacks, as requested in #22877.

Changes

Checklist

  • Either (a) I've created an enhancement proposal and discussed it with the community,
    (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR guidelines.
  • I've included Fixes #22877 in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them. (not applicable)
  • Does this PR require documentation updates? (likely no)
  • I've updated documentation as required by this PR. (if not needed, leave unchecked)
  • I have signed off all my commits as required by DCO.
  • I have written unit and/or e2e tests for my change.
  • My build is green.
  • I have added a brief description of why this PR is necessary and what it solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into.

@Sapthagiri777 Sapthagiri777 requested a review from a team as a code owner December 20, 2025 22:50
@bunnyshell
Copy link

bunnyshell bot commented Dec 20, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.61%. Comparing base (b543e18) to head (6a4c892).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25760      +/-   ##
==========================================
- Coverage   62.63%   62.61%   -0.02%     
==========================================
  Files         353      353              
  Lines       50159    50160       +1     
==========================================
- Hits        31416    31408       -8     
- Misses      15725    15736      +11     
+ Partials     3018     3016       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you go and fix the lint checks please?

- Add X-Frame-Options: DENY header to Swagger UI responses
- Prevents clickjacking attacks by blocking iframe embedding
- Fixes argoproj#22877

Signed-off-by: Sapthagiri777 <[email protected]>
@Sapthagiri777 Sapthagiri777 force-pushed the feat/add-x-frame-options-header branch from 6829f30 to dcfa20e Compare December 21, 2025 11:58
@Sapthagiri777
Copy link
Author

“Hi @nitishfy , the lint issues and DCO are fixed, and all checks are green. Please let me know if anything else is needed.”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add X-Frame-Options header to Swagger UI to prevent clickjacking

2 participants