-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat: Add generic/external jwt authentication (Alpha) #25567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Brian Groux <[email protected]>
Signed-off-by: Brian Groux <[email protected]>
71f0f30 to
ba7edb9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #25567 +/- ##
=========================================
Coverage ? 62.52%
=========================================
Files ? 354
Lines ? 50258
Branches ? 0
=========================================
Hits ? 31425
Misses ? 15800
Partials ? 3033 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Brian Groux <[email protected]>
bf29c6d to
516a883
Compare
Signed-off-by: Brian Groux <[email protected]>
516a883 to
583aeb6
Compare
Signed-off-by: Brian Groux <[email protected]>
c45238b to
9c1e33c
Compare
Signed-off-by: Brian Groux <[email protected]>
07e7046 to
c319de3
Compare
Signed-off-by: Brian Groux <[email protected]>
c319de3 to
733e56c
Compare
Signed-off-by: Brian Groux <[email protected]>
e088df6 to
de185eb
Compare
Signed-off-by: Brian Groux <[email protected]>
de185eb to
cdb62dd
Compare
| @@ -0,0 +1,258 @@ | |||
| package token | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super happy with the util/jwt/token package being added but there's a nasty import cycle because we need settings in here which imports a ton of things and the util/jwt package is used is a ton places some of which are imported by settings ... it was either this or push settings behind an interface local to the jwt package which felt even uglier ¯\_(ツ)_/¯
Signed-off-by: Brian Groux <[email protected]>
Closes #14250
Based on: #20928, #22901
Feature implemented by @wrmedford
Contributions by @alexander-applyinnovations
This allows for generic JWTs to be used for authentication that are minted outside of Argo. Argo currently mints its own JWTs for auth outside of Dex, and this extends its capabilities to utilize JWTs that originate from Identity Aware Proxies.
PR structure;
Checklist: