Skip to content

Bugfix/startup selecting folder #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions backend/menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const openAboutWindow = require('about-window').default

module.exports = function registerMenu(win) {
const isMac = process.platform === 'darwin'
const isDev = !app.isPackaged
const template = [
...(isMac ? [{
label: app.name,
Expand Down Expand Up @@ -56,17 +55,13 @@ module.exports = function registerMenu(win) {
label: 'View',
submenu: [
{ role: 'reload' },
{ role: 'toggleDevTools' },
{ type: 'separator' },
{ role: 'resetZoom' },
{ role: 'zoomIn' },
{ role: 'zoomOut' },
{ type: 'separator' },
{ role: 'togglefullscreen' },
...(isDev ? [
{ type: 'separator' },
{ role: 'toggleDevTools' },
]:[
])
]
},
{
Expand Down
4 changes: 2 additions & 2 deletions preload.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ const Serial = {
return ports.filter(p => p.vendorId && p.productId)
},
connect: async (path) => {
return await board.open(path)
return board.open(path)
},
disconnect: async () => {
return await board.close()
return board.close()
},
run: async (code) => {
return board.run(code)
Expand Down
1 change: 1 addition & 0 deletions ui/arduino/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
<script type="text/javascript" src="views/components/repl-panel.js" charset="utf-8"></script>
<script type="text/javascript" src="views/components/tabs.js" charset="utf-8"></script>
<script type="text/javascript" src="views/components/toolbar.js" charset="utf-8"></script>
<script type="text/javascript" src="views/components/overlay.js" charset="utf-8"></script>

<!-- Views -->
<script type="text/javascript" src="views/editor.js" charset="utf-8"></script>
Expand Down
35 changes: 18 additions & 17 deletions ui/arduino/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,27 +19,26 @@ function App(state, emit) {
`
}

let overlay = html`<div id="overlay" class="closed"></div>`

if (state.diskFiles == null) {
emit('load-disk-files')
overlay = html`<div id="overlay" class="open"><p>Loading files...</p></div>`
if (state.view == 'file-manager') {
return html`
<div id="app">
${FileManagerView(state, emit)}
${Overlay(state, emit)}
</div>
`
} else {
return html`
<div id="app">
${EditorView(state, emit)}
${Overlay(state, emit)}
</div>
`
}

if (state.isRemoving) overlay = html`<div id="overlay" class="open"><p>Removing...</p></div>`
if (state.isConnecting) overlay = html`<div id="overlay" class="open"><p>Connecting...</p></div>`
if (state.isLoadingFiles) overlay = html`<div id="overlay" class="open"><p>Loading files...</p></div>`
if (state.isSaving) overlay = html`<div id="overlay" class="open"><p>Saving file... ${state.savingProgress}</p></div>`
if (state.isTransferring) overlay = html`<div id="overlay" class="open"><p>Transferring file... ${state.transferringProgress}</p></div>`

const view = state.view == 'editor' ? EditorView(state, emit) : FileManagerView(state, emit)
return html`
<div id="app">
${view}
${overlay}
${Overlay(state, emit)}
</div>
`

}

window.addEventListener('load', () => {
Expand All @@ -49,7 +48,9 @@ window.addEventListener('load', () => {
app.mount('#app')

app.emitter.on('DOMContentLoaded', () => {
app.emitter.emit('refresh-files')
if (app.state.diskNavigationRoot) {
app.emitter.emit('refresh-files')
}
})

})
16 changes: 16 additions & 0 deletions ui/arduino/views/components/overlay.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
function Overlay(state, emit) {
let overlay = html`<div id="overlay" class="closed"></div>`

if (state.diskFiles == null) {
emit('load-disk-files')
overlay = html`<div id="overlay" class="open"><p>Loading files...</p></div>`
}

if (state.isRemoving) overlay = html`<div id="overlay" class="open"><p>Removing...</p></div>`
if (state.isConnecting) overlay = html`<div id="overlay" class="open"><p>Connecting...</p></div>`
if (state.isLoadingFiles) overlay = html`<div id="overlay" class="open"><p>Loading files...</p></div>`
if (state.isSaving) overlay = html`<div id="overlay" class="open"><p>Saving file... ${state.savingProgress}</p></div>`
if (state.isTransferring) overlay = html`<div id="overlay" class="open"><p>Transferring file... ${state.transferringProgress}</p></div>`

return overlay
}