[PHID] Fixes protocol on reenumeration #3966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional notes:
The USB Core should also made more disconnect proof. If the device suddenly disconnects the usb might hang forever. Other bugs occur at reenumeration. This is mostly a problem if you power the Arduino from external power/battery.
This PR makes "no sense/use" at all since the get protocol is not implemented. But since we have the variable, we should at least correct this bug or fully remove it. If you fully remove it I suggest to comment the lines to let others know that this feature should exist. I'd vote for implementing the get request so its fully usb compatible. Send8() must then be placed inside some header file.
Just for debugging reasons here a small debug output on reenumeration: