Add ApolloStore.close() and NormalizedCache.close()
#6299
Conversation
✅ Docs Preview ReadyNo new or changed pages found. |
| /** | ||
| * Closes resources associated with the cache if any. | ||
| * This function must not call `nextCache.close()`, this is done by the caller. | ||
| */ | ||
| override fun close() { | ||
| } |
There was a problem hiding this comment.
I went with SqlNormalizedCache.close() and not SqlNormalizedCacheFactory.close() because I think it makes more sense? Ultimately, SqlNormalizedCacheFactory may be turned into a plain Kotlin function like we have () -> OkHttpClient for lazy initialization, we could have () -> NormalizedCache, this is the same pattern.
There was a problem hiding this comment.
Yes, that's more intuitive than a closeable factory 👍
Now if a driver is passed, or a factory is re-used, apolloStore.close() must be called with caution. Should we call that out, maybe in the KDoc of the SqlNormalizedCacheFactory(driver: SqlDriver) constructor?
| * Closes resources associated with the cache if any. | ||
| * This function must not call `nextCache.close()`, this is done by the caller. |
There was a problem hiding this comment.
It's very easy to forget calling nextCache.close() so I went with this but no strong opinion there.
|
This has been open far too long. I'll get back to it at some point. In the meantime, closing it. |
See #6281
See apollographql/apollo-kotlin-normalized-cache#67
See apollographql/apollo-kotlin-normalized-cache#66