This repository was archived by the owner on Nov 8, 2024. It is now read-only.
feat(core): dereference elements with valueOf #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricksmms
force-pushed
the
patricksmms/improve-define-value-of
branch
from
94a81b6 to
63c5a14
Compare
patricksmms
force-pushed
the
patricksmms/improve-define-value-of
branch
from
63c5a14 to
7764adf
Compare
kylef
reviewed
Sep 18, 2020
packages/api-elements/lib/utils.js
Outdated
| * Get element attribute | ||
| * @param {element} e - element - element | ||
| * @param {string} attribute | ||
| * @return {boolean} |
There was a problem hiding this comment.
I think this isn't true, getAttribute would return Element (member value) or undefined.
There was a problem hiding this comment.
Addressed on cdeebcf
packages/api-elements/lib/utils.js
Outdated
| */ | ||
| const isOptional = e => hasTypeAttribute(e, 'optional'); | ||
|
|
||
| const baseTypes = new Set(['boolean', 'string', 'number', 'array', 'object', 'enum']); |
There was a problem hiding this comment.
Should this include null?
There's also other refract base types:member, select, option, extend, ref and link (https://apielements.org/en/latest/element-definitions.html#data-structure-element-types) elements. Although perhaps for purposes of check you don't want those.
There was a problem hiding this comment.
It makes sense to add them all to the list.
There was a problem hiding this comment.
Addressed on add7f25
patricksmms
added a commit
that referenced
this pull request
Sep 18, 2020
patricksmms
added a commit
that referenced
this pull request
Sep 18, 2020
kylef
approved these changes
Sep 23, 2020
patricksmms
force-pushed
the
patricksmms/improve-define-value-of
branch
from
ea823ff to
60121f0
Compare
kylef
approved these changes
Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.