wip: refactor abstract mapreduce#9177
Draft
emilygilberts wants to merge 4 commits intoapache:masterfrom
Draft
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did some ES6 refactoring:
converted functions
updatePurgeSeq, saveKeyValues, createTask, getRecentPurgestoasync/awaitto replace promise chainsrefactored postProcessAttatchments
to accept the resolved result (res) directly, wich enables to remove the.then()` on the callremoved unneccessary promise wrappers around calls of:
postProcessAttatchments(is now invoked directly with the resolved result - instead of with.then()chaining)queryPromised(the async function already returns a promise)replaced the use of
fin(final promise factory function) withtry/finallyblockremoved the last
varrewrote the
defaultsTofunction that sets a default value if a promise throws a 404 error - which used to fit neatly into the.catch(defaultsTo(x).then(..)syntax, but couldn't be used anymore after the rewrite. I added an optionalpropertyparameter to the function, as we sometimes want to return the awaited result directly (ex.lastSeqDocinsaveKeyValues) and sometimes a property of it (ex.purqueSeq._revinupdatePurgeSeq). This part was most confusing for me - so I'm happy for any thoughts on it!