Add fuzz targets for OSS-Fuzz integration (RLE + FormulaParser)#1020
Add fuzz targets for OSS-Fuzz integration (RLE + FormulaParser)#1020vishalcoc44 wants to merge 5 commits intoapache:trunkfrom
Conversation
pjfanning
left a comment
There was a problem hiding this comment.
These 2 files need Apache source headers like the ones in existing files in this repo. The Google copyright in one file. Is this needed? Provide full details if yes.
If you we do need a Google copyright then you need to also update the LICENSE file in this repo to mention this file with Google copyright code.
Thanks @pjfanning! I've addressed both points:
|
|
Hey @pjfanning there were some build errors due to the jazzer api . I've made the required changes.
|
poi/src/test/java9/module-info.java
Outdated
| requires org.junit.jupiter.api; | ||
| requires org.junit.jupiter.params; | ||
| requires org.mockito; | ||
| requires static com.code_intelligence.jazzer.api; |
There was a problem hiding this comment.
let's not do this - move the code out of here into its own module if this is needed
There was a problem hiding this comment.
Can't you even host this change yourself? Why does this code need to be in POI repo. It can be in any arbitrary Git repo.
|
If you want to proceed with this PR in this repo, don't update the Ant build. It is already a millstone around our necks and it doesn't need to support everything. Don't break the Ant build but if we add a new poi-fuzz module then we don't need the Ant build to support it. Concentrate on the Gradle build. |
Hi @centic9,
I'm contributing two fuzz targets for integration with Google's OSS-Fuzz continuous fuzzing platform. The OSS-Fuzz maintainers have requested that they be upstreamed.
POIRleFuzzer for RLEDecompressingInputStream
FormulaParserFuzzer for FormulaParser.parse()
[[) cause a RuntimeException ("Parsed past the end of the formula") instead of a proper FormulaParseException (confirmed in POI 5.2.3).FormulaParser.parse("[[", workbook, FormulaType.CELL, -1)Thanks for taking the time to review.