Skip to content

MINOR: Use a separate map to store acknowledgements in ShareAcknowledgementEvent. #20924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ShivsundarR wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

MINOR: Use a separate map to store acknowledgements in ShareAcknowledgementEvent. #20924

ShivsundarR wants to merge 1 commit into from
+2 −1

Conversation

@ShivsundarR
Copy link
Contributor

@ShivsundarR ShivsundarR commented Nov 19, 2025 •
edited by github-actions bot
Loading

What

  • Currently we are passing down the same map in
    ShareAcknowledgementEvent to the application thread for callback
    processing. But this map could be modified in the
    ShareConsumeRequestManager, and could result in inconsistent data.
  • This was a bug in
    403f6c1#diff-918e750d3f1c79f14a8489b1b56b95a07528755cd4303b525eb6da13217447df
    when ShareAcknowledgementEvent was introduced.
  • This PR uses a separate map every time an event is created.

Reviewers: Andrew Schofield [email protected]

@github-actions github-actions bot added triage PRs from the community consumer clients small Small PRs labels Nov 19, 2025
@AndrewJSchofield AndrewJSchofield added KIP-932 Queues for Kafka ci-approved and removed triage PRs from the community labels Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci-approved clients consumer KIP-932 Queues for Kafka small Small PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShivsundarR @AndrewJSchofield