-
Notifications
You must be signed in to change notification settings - Fork 14.4k
MINOR: Cleanup JMH-Benchmarks Module #19791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Thanks for the PR. Could you also do this cleanup? |
Thanks @Yunyung for the review. I have addressed the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sjhajharia for this patch, left a comment
@@ -189,7 +187,7 @@ private Optional<String> rackId(int memberIndex) { | |||
private static Map<Integer, Set<String>> mkMapOfPartitionRacks(int numPartitions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this mkMapOfPartitionRacks
method is unused, we should remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mkMapOfPartitionRacks will be removed all at once in #19797, so it's fine here.
Please resolve the conflict, thanks |
Hey @m1a2st |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
cc: @frankvicky |
Now that Kafka supports Java 17, this PR makes some changes in
jmh-benchmarks module. The changes mostly include:
Arrays.asList() are replaced with List.of()
with Map.of()