KAFKA-19285: Added more tests in SharePartitionManagerTest #19778
+191
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
AndrewJSchofield
requested changes
May 21, 2025
| assertInstanceOf(ShareSessionContext.class, context1); | ||
| assertFalse(((ShareSessionContext) context1).isSubsequent()); | ||
|
|
||
| // The expected epoch from the share session should be 1, but we are passing 2. This should throw an exception. |
There was a problem hiding this comment.
Aren't we passing FINAL_EPOCH?
| // The expected epoch from the share session should be 1, but we are passing 2. This should throw an exception. | ||
| assertDoesNotThrow( | ||
| () -> sharePartitionManager.acknowledgeSessionUpdate("grp", | ||
| new ShareRequestMetadata(memberId, ShareRequestMetadata.nextEpoch(ShareRequestMetadata.INITIAL_EPOCH)))); |
There was a problem hiding this comment.
Aren't we passing 1? The next epoch after the initial epoch is 1, isn't it?
| assertInstanceOf(ShareSessionContext.class, context1); | ||
| assertFalse(((ShareSessionContext) context1).isSubsequent()); | ||
|
|
||
| // The expected epoch from the share session should be 1, but we are passing 2. This should throw an exception. |
There was a problem hiding this comment.
Thanks for the review. I understand the other places I forgot to update the log, but I believe in this referred place it is fine. The code does the following ->
ShareRequestMetadata.nextEpoch(ShareRequestMetadata.nextEpoch(ShareRequestMetadata.INITIAL_EPOCH))
ShareRequestMetadata.nextEpoch() is called twice, thereby increasing epoch from 0 to 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes more unit tests in the file SharePartitionManagerTest to improve the coverage