Skip to content

KAFKA-7516: Attempt to dynamically load ManagementFactory #19764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gtbX wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-7516: Attempt to dynamically load ManagementFactory #19764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b92515
Attempt to dynamically load ManagementFactory class;
gtbX Nov 28, 2024
b8da06d
Restore caught exception types
gtbX Nov 28, 2024
d699271
Encapsulate getMBeanServer for testing
gtbX May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import org.slf4j.LoggerFactory;

import java.io.InputStream;
import java.lang.management.ManagementFactory;
import java.util.Properties;

import javax.management.JMException;
Expand All @@ -50,6 +49,20 @@ public class AppInfoParser {
COMMIT_ID = props.getProperty("commitId", DEFAULT_VALUE).trim();
}

static MBeanServer getPlatformMBeanServer(ClassLoader loader) {
try {
// Not all platforms (*cough*Android*cough*) have MBeans, query using reflection
Class<?> managementFactory = Class.forName("java.lang.management.ManagementFactory", true, loader);
return (MBeanServer) managementFactory.getMethod("getPlatformMBeanServer").invoke(null);
} catch (ReflectiveOperationException e) {
return null;
}
}

static MBeanServer getPlatformMBeanServer() {
return getPlatformMBeanServer(AppInfoParser.class.getClassLoader());
}

public static String getVersion() {
return VERSION;
}
Expand All @@ -59,9 +72,12 @@ public static String getCommitId() {
}

public static synchronized void registerAppInfo(String prefix, String id, Metrics metrics, long nowMs) {
MBeanServer server = getPlatformMBeanServer();
if (server == null) {
return;
}
try {
ObjectName name = new ObjectName(prefix + ":type=app-info,id=" + Sanitizer.jmxSanitize(id));
MBeanServer server = ManagementFactory.getPlatformMBeanServer();
if (server.isRegistered(name)) {
log.info("The mbean of App info: [{}], id: [{}] already exists, so skipping a new mbean creation.", prefix, id);
return;
Expand All @@ -76,7 +92,10 @@ public static synchronized void registerAppInfo(String prefix, String id, Metric
}

public static synchronized void unregisterAppInfo(String prefix, String id, Metrics metrics) {
MBeanServer server = ManagementFactory.getPlatformMBeanServer();
MBeanServer server = getPlatformMBeanServer();
if (server == null) {
return;
}
try {
ObjectName name = new ObjectName(prefix + ":type=app-info,id=" + Sanitizer.jmxSanitize(id));
if (server.isRegistered(name))
Expand Down
18 changes: 18 additions & 0 deletions clients/src/test/java/org/apache/kafka/common/utils/AppInfoParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;

Expand All @@ -55,6 +56,23 @@ public void tearDown() {
metrics.close();
}

@Test
public void testGetPlatformMBeanServer() {
assertNotNull(AppInfoParser.getPlatformMBeanServer(AppInfoParser.class.getClassLoader()));
}

@Test
public void testFailGetPlatformMBeanServer() {
ClassLoader nullLoader = new ClassLoader(null) {
@Override
public Class<?> loadClass(String name) throws ClassNotFoundException {
throw new ClassNotFoundException(name);
}
};

assertNull(AppInfoParser.getPlatformMBeanServer(nullLoader));
}

@Test
public void testRegisterAppInfoRegistersMetrics() throws JMException {
registerAppInfo();
Expand Down