Skip to content

HBASE-30126 Fix mismatched LoggerFactory class references#8161

Merged
liuxiaocs7 merged 1 commit intoapache:branch-2.6from
liuxiaocs7:HBASE-30126-branch-2.6
Apr 29, 2026
Merged

HBASE-30126 Fix mismatched LoggerFactory class references#8161
liuxiaocs7 merged 1 commit intoapache:branch-2.6from
liuxiaocs7:HBASE-30126-branch-2.6

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label Apr 29, 2026
@liuxiaocs7 liuxiaocs7 requested a review from Copilot April 29, 2026 03:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR (HBASE-30126, branch-2.6) fixes mismatched LoggerFactory.getLogger(...) class references so log categories correctly reflect the declaring class across several modules (server, thrift, http, mapreduce, metrics, compat, and tests).

Changes:

  • Update SLF4J logger initialization to use the local declaring class instead of unrelated classes.
  • Remove a now-unused import in TestRegionReplicaFailover after correcting its logger class reference.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java Log category now matches HThreadedSelectorServerArgs.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALCorruptionDueToDanglingByteBufferTestBase.java Log category now matches the test base class.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitToHFile.java Log category now matches TestWALSplitToHFile.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestMobFlushSnapshotFromClient.java Log category now matches TestMobFlushSnapshotFromClient.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestConcurrentFlushSnapshotFromClient.java Log category now matches TestConcurrentFlushSnapshotFromClient.
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java Log category now matches TestAccessController3.
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestWALEntrySinkFilter.java Log category now matches TestWALEntrySinkFilter.
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStuckWithDroppedTable.java Log category now matches TestReplicationStuckWithDroppedTable.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java Log category now matches TestLogRollAbort.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaFailover.java Log category now matches TestRegionReplicaFailover; removes unused import.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java Log category now matches TestHRegionReplayEvents.
hbase-server/src/test/java/org/apache/hadoop/hbase/namequeues/TestWALEventTracker.java Log category now matches TestWALEventTracker.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureEvents.java Log category now matches TestMasterProcedureEvents.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java Log category now matches TestMasterOperationsForRegionReplicas.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestDLS.java Log category now matches AbstractTestDLS.
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java Log category now matches AbstractRecoveredEditsOutputSink.
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java Log category now matches CanaryTool.
hbase-server/src/main/java/org/apache/hadoop/hbase/security/provider/SaslServerAuthenticationProviders.java Log category now matches SaslServerAuthenticationProviders.
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceLogQueue.java Log category now matches ReplicationSourceLogQueue.
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java Log category now matches HFilePreadReader.
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java Log category now matches MultiRowMutationEndpoint.
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java Log category now matches ZKSplitLogManagerCoordination.
hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java Log category now matches MetricRegistriesLoader.
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Inner mapper class log category now matches CellSortImporter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestServletFilter.java Log category now matches TestServletFilter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestPathFilter.java Log category now matches TestPathFilter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestGlobalFilter.java Log category now matches TestGlobalFilter.
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java Log category now matches CompatibilityFactory.
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/ReusableStreamGzipCodec.java Log category now matches ReusableStreamGzipCodec.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java Log category now matches RawAsyncHBaseAdmin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 merged commit 05fd18b into apache:branch-2.6 Apr 29, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants