Skip to content

HBASE-30126 Fix mismatched LoggerFactory class references#8160

Merged
liuxiaocs7 merged 1 commit intoapache:branch-2from
liuxiaocs7:HBASE-30126-branch-2
Apr 29, 2026
Merged

HBASE-30126 Fix mismatched LoggerFactory class references#8160
liuxiaocs7 merged 1 commit intoapache:branch-2from
liuxiaocs7:HBASE-30126-branch-2

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 requested a review from Copilot April 29, 2026 03:55
@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label Apr 29, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes incorrect/mismatched LoggerFactory.getLogger(...) class references across several modules (including tests), aligning logger categories with the class that actually owns the LOG/LOGGER field (per HBASE-30126, branch-2).

Changes:

  • Update many private static final Logger LOG/LOGGER initializations to use the enclosing class rather than an unrelated class.
  • Remove now-unneeded imports where the only usage was the old logger class reference.

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java Fix logger category to use HThreadedSelectorServerArgs.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALCorruptionDueToDanglingByteBufferTestBase.java Fix logger category to use the test base class.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitToHFile.java Fix logger category to use TestWALSplitToHFile.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotWhenChoreCleaning.java Fix logger category to use TestSnapshotWhenChoreCleaning.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestMobFlushSnapshotFromClient.java Fix logger category to use TestMobFlushSnapshotFromClient.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestConcurrentFlushSnapshotFromClient.java Fix logger category to use TestConcurrentFlushSnapshotFromClient (with wrapping).
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java Fix logger category to use TestAccessController3.
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestWALEntrySinkFilter.java Fix logger category to use TestWALEntrySinkFilter.
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStuckWithDroppedTable.java Fix logger category to use TestReplicationStuckWithDroppedTable.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java Fix logger category to use TestLogRollAbort.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaFailover.java Fix logger category to use TestRegionReplicaFailover; remove unused import.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java Fix logger category to use TestHRegionReplayEvents.
hbase-server/src/test/java/org/apache/hadoop/hbase/namequeues/TestWALEventTracker.java Fix logger category to use TestWALEventTracker.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureEvents.java Fix logger category to use TestMasterProcedureEvents.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java Fix logger category to use TestMasterOperationsForRegionReplicas (with wrapping).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestDLS.java Fix logger category to use AbstractTestDLS.
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestPostIncrementAndAppendBeforeWAL.java Fix logger category to use TestPostIncrementAndAppendBeforeWAL; remove unused import.
hbase-server/src/test/java/org/apache/hadoop/hbase/client/BasicReadWriteWithDifferentConnectionRegistriesTestBase.java Fix logger category to use the test base class.
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java Fix logger category to use AbstractRecoveredEditsOutputSink.
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java Fix logger category to use CanaryTool (instead of Canary).
hbase-server/src/main/java/org/apache/hadoop/hbase/security/provider/SaslServerAuthenticationProviders.java Fix logger category to use SaslServerAuthenticationProviders.
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceLogQueue.java Fix logger category to use ReplicationSourceLogQueue.
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java Fix logger category to use HFilePreadReader.
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java Fix logger category to use MultiRowMutationEndpoint.
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java Fix logger category to use ZKSplitLogManagerCoordination.
hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java Fix logger category to use MetricRegistriesLoader.
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Fix logger category for CellSortImporter inner class.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestServletFilter.java Fix logger category to use TestServletFilter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestPathFilter.java Fix logger category to use TestPathFilter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestGlobalFilter.java Fix logger category to use TestGlobalFilter.
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java Fix logger category to use CompatibilityFactory.
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/ReusableStreamGzipCodec.java Fix logger category to use ReusableStreamGzipCodec.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java Fix logger category to use RawAsyncHBaseAdmin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 closed this Apr 29, 2026
@liuxiaocs7 liuxiaocs7 reopened this Apr 29, 2026
@liuxiaocs7 liuxiaocs7 force-pushed the HBASE-30126-branch-2 branch from 4baff25 to 4891e14 Compare April 29, 2026 04:53
@liuxiaocs7
Copy link
Copy Markdown
Member Author

Falied UT are not related, Let me merge

@liuxiaocs7 liuxiaocs7 merged commit 3c8c806 into apache:branch-2 Apr 29, 2026
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants