[docs] Fix misaligned rowspans in Table/Bucket metrics table#3624
Open
orangeCatDeveloper wants to merge 1 commit into
Open
[docs] Fix misaligned rowspans in Table/Bucket metrics table#3624orangeCatDeveloper wants to merge 1 commit into
orangeCatDeveloper wants to merge 1 commit into
Conversation
The tabletserver, table_bucket_log and table_bucket_remoteLog rowspans were smaller than the number of rows in each group, shifting the trailing rows into the wrong columns. Correct the counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #2812
The Table/Bucket table on the Monitor Metrics page renders misaligned in the current (
next) docs.The table is written as raw HTML and uses
rowspanto group rows by scope/infix. Threerowspanvalues were left smaller than the number of rows actually in each group:rowspantabletserver(scope)30→31table_bucket_log(infix)2→3table_bucket_remoteLog(infix)3→4Because each group spans one row too few, the trailing rows (
endOffset,size,kvSize) shift left into the wrong columns — the metric name lands under Metrics, the type under Description, and Type is left blank;kvSizeeven bleeds into the Scope column.Note — this is not a duplicate of the already-merged #2813. #2813 fixed the misaligned tables as they were at that time (including the Coordinator Server table shown in the #2812 screenshot, which now renders correctly). Afterwards, the
startOffsetrows were added to thetable_bucket_logandtable_bucket_remoteLoggroups without bumping theirrowspan, so the Table/Bucket table broke again. #2812 is still open, and this PR fixes the remaining/regressed table that #2813 did not cover. The released docs are unaffected — the breakage is only visible in thenext(development) version.Brief change log
rowspancounts fortabletserver,table_bucket_log, andtable_bucket_remoteLoginwebsite/docs/maintenance/observability/monitor-metrics.md.Screenshots
Before:
After:
Tests
Docs-only change. Built the site locally (
docusaurus build) with no new broken links, and verified every HTML table on the page now aligns (eachrowspanmatches its group's row count).API and Format
No API or storage format changes.
Documentation
This PR is a documentation fix.