[FLINK-39916][mysql] Fix MySQL batch startup option validation error#4441
Merged
lvyanquan merged 2 commits intoJul 3, 2026
Merged
Conversation
llphxd
changed the title
Signed-off-by: huanxiaodong <llphxdgg@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an incorrect placeholder in a MySQL pipeline connector validation error so the actual startup option is rendered correctly when running in BATCH mode.
Changes:
- Replace SLF4J-style
{}withString.format’s%sin the BATCH startup option validation error message. - Remove an unused private constant (
DOT_PLACEHOLDER) fromMySqlDataSourceFactory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes an incorrect placeholder used in the MySQL Pipeline Connector batch startup option validation error.
JIRA
FLINK-39916
Change log
Replace the SLF4J-style
{}placeholder with the JavaString.formatplaceholder%sinMySqlDataSourceFactory.java, so the actual startup option can be rendered correctly in the thrownIllegalArgumentException.Additional Cleanup: Remove an unused
DOT_PLACEHOLDERconstant fromMySqlDataSourceFactory.java.Verifying this change
This is a small validation error output fix with no test coverage added.
Why are the changes needed?
{}placeholder when an unsupported MySQL startup option is used in BATCH pipeline mode.How was this patch tested?