fix:openapi #15806
Open
fix:openapi #15806
+168
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15806 +/- ##
============================================
- Coverage 60.75% 60.72% -0.04%
- Complexity 11695 11700 +5
============================================
Files 1938 1938
Lines 88679 88752 +73
Branches 13386 13403 +17
============================================
+ Hits 53877 53892 +15
- Misses 29270 29326 +56
- Partials 5532 5534 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@heliang666s PTAL |
oxsean
reviewed
Nov 28, 2025
| schema.setDeprecated(anno.deprecated() ? Boolean.TRUE : null); | ||
|
|
||
| return chain.resolve(parameter, context); | ||
| return schema; |
redoom
commented
Nov 30, 2025
Contributor
Author
There was a problem hiding this comment.
Because it has already been called once here, if it is called again, it will be called twice. So I directly returned the schema. I believe the schema annotation is failing because it's being called an extra time at the end, which prevents the preceding set methods from taking effect.
@oxsean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix two critical issues in Dubbo REST OpenAPI schema resolution for generic nested types:
Generic nested type resolution incomplete - Schemas for intermediate generic types (e.g.,
PageResponseinApiResponse<PageResponse<AccessLogRes>>) were completely missingAnnotated fields disappearing or losing annotation metadata - Fields with
@Schemaannotations were filtered out, anddescription/exampleproperties were not displayedBefore Fix
{ "AccessLogRes": { "properties": { "userId": { "type": "string" }, "createTime": { "format": "date-time", "type": "string" } } } }Missing
idandactionfieldsNo description or example in any field
After Fix
{ "AccessLogRes": { "properties": { "id": { "type": "string", "description": "操作ID", "example": "123456" }, "userId": { "type": "string" }, "action": { "type": "string", "description": "操作类型", "example": "LOGIN" }, "createTime": { "format": "date-time", "type": "string" } } } }All 4 fields present
Annotation metadata (description, example) properly displayed
Related Issues
#15718