[fix](regression) Restore time zone after test_tz_load#65412
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
/review |
There was a problem hiding this comment.
Static review completed for PR #65412.
I found no blocking issue and am leaving this as a comment-only review. The patch is narrowly scoped to regression-suite isolation in test_tz_load: it captures @@global.time_zone, restores it in finally, and removes the temporary global_timezone_test table without changing the query assertions or expected output.
Critical checkpoint conclusions:
- Goal and proof: the change addresses the leaked global
time_zonefrom this nonConcurrent suite; the existing orderedqt_global_offsetchecks and expected output remain unchanged. - Scope: one regression test file, small and focused.
- Concurrency/lifecycle: no production concurrency is involved; the relevant lifecycle is global/session test state, and
SET GLOBALis restored infinally. - Config/session propagation: Doris
VariableMgr.setVarInternalappliesSET GLOBALto both global default state and the current session, so restoring the saved global value covers the state this suite mutates. - Compatibility and parallel paths: no storage format, FE/BE protocol, or production behavior changes; explicit timezone and default/global timezone load paths remain covered.
- Test result correctness: no
.outupdate is needed because the result-producing SQL is unchanged and ordered. - Data writes, transactions, persistence, observability, and performance: not applicable to this regression-only cleanup.
Subagent conclusions:
optimizer-rewrite: no optimizer/rewrite, semantic-equivalence, join, or aggregate-path candidate; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.tests-session-config: no regression-output, session/config, compatibility, or basic style candidate; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.
User focus: no additional user-provided review focus was supplied.
Validation notes: I used GitHub PR metadata/patch as the authoritative scope because this runner is a grafted checkout and is missing the base SHA, .worktree_initialized, and thirdparty/installed. Existing inline comments were empty. The GitHub patch reverse-check passed with git apply -R --check --whitespace=error. I did not run the regression test or a build locally in this environment.
|
/run buildall |
Summary
Evidence
Testing