[Feature](function) Support function DAMERAU_LEVENSHTEIN_DISTANCE#65278
Open
linrrzqqq wants to merge 1 commit into
Open
[Feature](function) Support function DAMERAU_LEVENSHTEIN_DISTANCE#65278linrrzqqq wants to merge 1 commit into
linrrzqqq wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
738ef39 to
e875c26
Compare
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated review completed for PR #65278.
I found no blocking correctness issues and no inline comments to submit.
Critical checkpoint conclusions:
- Goal and tests: The PR adds
damerau_levenshtein_distancepluslevenshtein_distance/edit_distancealiases. FE binding, FE constant folding, BE execution, and regression coverage are present for literal, vector/vector, vector/scalar, NULL, UTF-8, transposition, and oversized matrix cases. - Scope: The function changes are focused on the string-distance implementation, FE scalar registration, executable folding, benchmark coverage, and one regression suite.
- Concurrency, lifecycle, persistence, and configuration: Not applicable; this is a deterministic scalar function addition with no new shared state, config, persistence, RPC, or lifecycle path.
- FE/BE compatibility: FE and BE expose matching names and return
INT; aliases map consistently, and the FE/BE Damerau implementations use the same full recurrence and 16M-cell guard. - Parallel paths: Runtime BE execution and FE constant folding were checked. The scalar follows the existing
Levenshteinnullable/signature pattern and does not require optimizer, join, aggregate, or property-derivation changes. - Test result review: The added
.outrows match an independent full Damerau-Levenshtein calculation for the covered cases. Patch whitespace/reverse-apply hygiene passed. - Validation limits: I did not run FE/BE builds or regression tests because this checkout lacks
thirdparty/installed/bin/protoc.
User focus: No additional user-provided review focus was supplied.
Subagent conclusions:
optimizer-rewrite: no optimizer/rewrite candidate findings; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.tests-session-config: no tests/session/config candidate findings; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.- No candidates were accepted, dismissed as duplicates, or submitted as inline comments.
Collaborator
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)