[branch-4.0][fix](be) Init thread context on AsyncIO worker threads#65271
Merged
morningman merged 1 commit intoJul 7, 2026
Merged
Conversation
`FILESYSTEM_M` dispatches IO ops from a bthread to an `AsyncIO` worker pthread that is **not bound to any task** and therefore has no `ThreadContext`. When the dispatched `fn()` reads a local file, it goes through `LocalFileReader::read_at_impl` -> `LIMIT_LOCAL_SCAN_IO` -> `thread_context()`, which raises `Status::FatalError` (aborting the BE in debug/ASAN builds) when no `ThreadContext` exists. Observed as a Cloud P0 coredump on the load error-log S3 upload path: ``` RuntimeState::get_error_log_file_path() -> _s3_error_fs->upload() (called from a bthread) -> AsyncIO::run_task() on an AsyncIO worker pthread (no attached task) -> S3FileSystem::upload_impl() -> LocalFileReader::read_at_impl() -> LIMIT_LOCAL_SCAN_IO -> thread_context() -> FatalError -> SIGABRT ``` Initialize an (unattached) `ThreadContext` at the `AsyncIO` worker boundary via `SCOPED_INIT_THREAD_CONTEXT()`, the same pattern used by StorageEngine background threads. This gives every `thread_context()` consumer running on an AsyncIO worker (memory tracking, `LIMIT_*_SCAN_IO`, ...) a valid context, fixing the crash at its root rather than making individual consumers tolerate a missing context.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports #64846 to ensure AsyncIO’s pthread-based worker threads have a valid ThreadContext before running dispatched filesystem work, preventing fatal failures when worker-side code touches thread_context() (e.g., memory tracking / IO limiting helpers).
Changes:
- Add
runtime/thread_context.hinclude to AsyncIO header. - Initialize an (unattached)
ThreadContextinside AsyncIO thread-pool task execution viaSCOPED_INIT_THREAD_CONTEXT().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
approved these changes
Jul 6, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick #64846