Perf: Optimize substring_index via single-byte fast path and direct indexing
#19590
+132
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR improves the performance of the
substring_indexfunction by optimizingdelimiter search and substring extraction:
.,,), avoiding UTF-8 pattern matching overhead.match_indices/rmatch_indices.What changes are included in this PR?
delimiter.len() == 1using byte-based search.match_indicesandrmatch_indicesfor more efficient positioning.Benchmarks
Are these changes tested?
Are there any user-facing changes?
No.